D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns added inline comments. INLINE COMMENTS > elvisangelaccio wrote in filemetadataconfigurationdialog.h:35 > Can you please also update this comment? It should mention > `Baloo::FileMetaDataWidget`. Good catch ... REPOSITORY R318 Dolphin REVISION DETAIL

D20513: Remove last traces of KFileMetaDataWidget from information panel

This revision was automatically updated to reflect the committed changes. Closed by commit R318:05a4d27813e3: Remove last traces of KFileMetaDataWidget from information panel (authored by bruns). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE

D20513: Remove last traces of KFileMetaDataWidget from information panel

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R318 Dolphin BRANCH arcpatch-D20513 REVISION DETAIL https://phabricator.kde.org/D20513 To: bruns, #frameworks, apol, ngraham, #dolphin,

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns updated this revision to Diff 56192. bruns added a comment. remove one more reference in comments REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20513?vs=56152=56192 BRANCH arcpatch-D20513 REVISION DETAIL https://phabricator.kde.org/D20513

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns marked an inline comment as done. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20513 To: bruns, #frameworks, apol, ngraham, #dolphin Cc: elvisangelaccio, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20513: Remove last traces of KFileMetaDataWidget from information panel

elvisangelaccio added inline comments. INLINE COMMENTS > filemetadataconfigurationdialog.h:35 > * @brief Dialog which allows to configure which meta data should be shown > *in the KFileMetaDataWidget. > */ Can you please also update this comment? It should mention

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns added a comment. In D20513#449484 , @ngraham wrote: > Won't this close the door on ever being able to implement something like https://bugs.kde.org/show_bug.cgi?id=406506? > > Not that the current UX is that great... Baloo in

D20513: Remove last traces of KFileMetaDataWidget from information panel

ngraham added a comment. Won't this close the door on ever being able to implement something like https://bugs.kde.org/show_bug.cgi?id=406506? Not that the current UX is that great... REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20513 To: bruns,

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns added a reviewer: Dolphin. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20513 To: bruns, #frameworks, apol, ngraham, #dolphin Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns created this revision. bruns added reviewers: Frameworks, apol, ngraham. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. bruns requested review of this revision. REVISION SUMMARY The whole information panel is not included when Baloo is not found, so there is no