D20606: Toggle folding of child ranges by right click

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. The question is: with a context menu, isn't that then already too inconvenient? At the moment we have no context menu for the bar at all. I could live with the right

D20606: Toggle folding of child ranges by right click

loh.tar added a comment. hm, there is already a folding action in the View menu. I understood Dominik so, not to add a context menu to the icon border, but to add the action to the context menu of the "edit range". Whatever, as said I'm not in the mood for that, and it should be done in

D20606: Toggle folding of child ranges by right click

loh.tar updated this revision to Diff 56444. loh.tar added a comment. - Add docu to header, not full happy with - Add desired adjustment checks - Make toggleFoldingInRange more action friendly - Add first try to unfold range itself into toggleFoldingInRange - Be a smart ass,

D20606: Toggle folding of child ranges by right click

mwolff added a comment. In D20606#451459 , @dhaumann wrote: > I would prefer a context menu that has this as action. This is much better discoverable and also extensible with more folding actions. I agree. Right-click should show a

D20606: Toggle folding of child ranges by right click

dhaumann added a comment. I would prefer a context menu that has this as action. This is much better discoverable and also extensible with more folding actions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20606 To: loh.tar, #ktexteditor, cullmann, ngraham,

D20606: Toggle folding of child ranges by right click

cullmann added reviewers: ngraham, dhaumann. cullmann added a comment. I think the feature is nice. For the code: I would like to have comments for the function decls. to tell what they really do. e.g. toggleFoldingInRange needs a short summary what it does, the comments in the

D20606: Toggle folding of child ranges by right click

loh.tar added a comment. Oh, may that fit too? Bug 352868 - Folding for all nodes (not just top-level) and/or siblings to current REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20606 To: loh.tar, #ktexteditor, cullmann Cc: kwrite-devel, kde-frameworks-devel,

D20606: Toggle folding of child ranges by right click

loh.tar added a comment. A possible improvement could be to add slots to make the folding accessible by some keyboard action, but I'm not in the mood for that now. Bug 343060 - global folding code keyboard shortcuts REPOSITORY R39 KTextEditor REVISION DETAIL

D20606: Toggle folding of child ranges by right click

loh.tar added a comment. This patch supersedes D20565 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20606 To: loh.tar, #ktexteditor, cullmann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham,

D20606: Toggle folding of child ranges by right click

loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY With this patch will all, and only, the nested