This revision was automatically updated to reflect the committed changes.
Closed by commit R286:61b1916c3e87: [TagLibExtractor] Fix crash on invalid
Speex files (authored by bruns).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20913?vs=57229=57281
astippich accepted this revision.
astippich added a comment.
Given the outcome, I wish I never added support for speex files to the
extractor because it was "easy to add".
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20913
To: bruns, #baloo, #frameworks,
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Gross! Confirmed the fix.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20913
To: bruns, #baloo, #frameworks, ngraham, astippich
Cc:
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
TagLib::Ogg::Speex::File::isValid() returns true even
