D21149: KAr::openArchive: Protect against Heap-buffer-overflow in broken files

2019-05-13 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D21149 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21149: KAr::openArchive: Protect against Heap-buffer-overflow in broken files

2019-05-13 Thread Albert Astals Cid
aacid added a comment. it's not a hot path since no one is using this since this didn't work until i fixed it last week. So basically this is just for fun/sport REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D21149 To: aacid, apol Cc: apol, kde-fra

D21149: KAr::openArchive: Protect against Heap-buffer-overflow in broken files

2019-05-12 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Q_ISUNLIKELY? I have no idea if it's a hot path, probably not, yet it could make sense as a way to say this is crazy-town error detection. REPOSITORY R243 KArchive BRANCH master REVI

D21149: KAr::openArchive: Protect against Heap-buffer-overflow in broken files

2019-05-12 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If size is negative there's no need to continue, file is broken REPOSITORY R243 KArchive BRANCH master REVISION DETAI