This revision was automatically updated to reflect the committed changes.
Closed by commit R245:c97f0b2a3076: Ensure mounted nfs filesystems matches
their fstab declared counterpart (authored by meven).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D21204?vs=67981=71566#toc
REPOSITORY
ngraham edited the summary of this revision.
REPOSITORY
R245 Solid
BRANCH
arcpatch-D21204
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol,
kde-frameworks-devel, LeGast00n, GB_2,
bruns added a comment.
please remove the 2 comments.
REPOSITORY
R245 Solid
BRANCH
arcpatch-D21204
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol,
kde-frameworks-devel, LeGast00n,
bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> fstabhandling.cpp:246
> +if (deviceName.endsWith(QLatin1Char('/'))) {
> +// remove trailing slash
> +deviceName.chop(1);
This comment is
meven updated this revision to Diff 67981.
meven marked an inline comment as done.
meven added a comment.
Avoid else after continue;
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21204?vs=65955=67981
BRANCH
arcpatch-D21204
REVISION DETAIL
meven edited the summary of this revision.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol,
kde-frameworks-devel, LeGast00n, GB_2, michaelh
bruns added inline comments.
INLINE COMMENTS
> fstabhandling.cpp:240
> +continue;
> +} else {
> +// deviceName will or won't end with / depending if device ended
> with one
No need to put this in `.. else {` after `continue`
REPOSITORY
R245 Solid
REVISION
meven updated this revision to Diff 65955.
meven added a comment.
Rebase on master, review feedback
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21204?vs=62027=65955
BRANCH
arcpatch-D21204
REVISION DETAIL
https://phabricator.kde.org/D21204
AFFECTED
meven marked an inline comment as done.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol,
kde-frameworks-devel, LeGast00n, GB_2, michaelh
bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> fstabhandling.cpp:236
> +auto device = it.key();
> +QString deviceName = device;
> +if (deviceName.endsWith(QLatin1Char('/'))) {
You
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Let's get this in soon. We have plenty of time before Frameworks 5.63.
REPOSITORY
R245 Solid
BRANCH
arcpatch-D21204
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven,
ngraham edited the summary of this revision.
REPOSITORY
R245 Solid
BRANCH
arcpatch-D21204
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol,
kde-frameworks-devel, LeGast00n, GB_2,
ngraham added a comment.
@bruns ping! :)
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol,
kde-frameworks-devel, LeGast00n, michaelh
ngraham added a comment.
@bruns, is this good to go now?
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol,
kde-frameworks-devel, LeGast00n, sbergeron, michaelh
meven updated this revision to Diff 62027.
meven added a comment.
Remove dead code
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21204?vs=60913=62027
BRANCH
arcpatch-D21204
REVISION DETAIL
https://phabricator.kde.org/D21204
AFFECTED FILES
meven marked 4 inline comments as done.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol,
kde-frameworks-devel, LeGast00n, michaelh
meven marked 2 inline comments as done.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol,
kde-frameworks-devel, LeGast00n, michaelh
meven updated this revision to Diff 60913.
meven added a comment.
Use an iterator to loop over globalFstabCache->m_fstabCache
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21204?vs=60855=60913
BRANCH
arcpatch-D21204
REVISION DETAIL
broulik added inline comments.
INLINE COMMENTS
> fstabhandling.cpp:227
> +QStringList devices = globalFstabCache->m_mtabCache.keys();
> +const QStringList fstabDevices = globalFstabCache->m_fstabCache.keys();
> +
Don't create a temporary `keys()` list just to iterate it. Use a loop like
meven retitled this revision from "Ensure mounted mounted nfs filesystems
matches their fstab declared counterpart" to "Ensure mounted nfs filesystems
matches their fstab declared counterpart".
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns,
20 matches
Mail list logo
