D21378: Make Breeze Light/Dark use more system colors

2019-05-29 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R242:fb8f02de76d5: Make Breeze Light/Dark use more system colors (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D21378: Make Breeze Light/Dark use more system colors

2019-05-26 Thread Noah Davis
ndavis added a comment. @mart If you're not opposed to this patch, I'll go ahead and land this. REPOSITORY R242 Plasma Framework (Library) BRANCH less-custom-colors (branched from master) REVISION DETAIL https://phabricator.kde.org/D21378 To: ndavis, #vdg, #plasma, mart, filipf Cc:

D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Peridot Lavender
lavender added a comment. In D21378#469640 , @filipf wrote: > In D21378#469611 , @ndavis wrote: > > > In D21378#469607 , @filipf wrote: > > > > > So I

D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Filip Fila
filipf added a comment. In D21378#469611 , @ndavis wrote: > In D21378#469607 , @filipf wrote: > > > So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme

D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Noah Davis
ndavis added a comment. In D21378#469607 , @filipf wrote: > So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a

D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Noah Davis
ndavis added a comment. In D21378#469525 , @lavender wrote: > In D21378#469517 , @mart wrote: > > > the idea is kinda nice and with some schemes it will work just perfect... > > however i think it

D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Filip Fila
filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a good

D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Peridot Lavender
lavender added a comment. In D21378#469517 , @mart wrote: > the idea is kinda nice and with some schemes it will work just perfect... > however i think it risks a lot of having loss in contrast on certain color schems with your patch try for

D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Marco Martin
mart added a comment. the idea is kinda nice and with some schemes it will work just perfect... however i think it risks a lot of having loss in contrast on certain color schems with your patch try for instance breezedark and the honeycomb system theme, the current task highlight would

D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham added a task: T8755: Use colors from the system colorscheme for the Task Manager's accent color in Breeze Light/Dark desktop themes. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21378 To:

D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Nathaniel Graham
ngraham added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21378 To: ndavis, #vdg, #plasma, mart Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Peridot Lavender
lavender added a comment. Tested and it looks good to me REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21378 To: ndavis, #vdg, #plasma Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Requested in T8755 REPOSITORY R242 Plasma