D21379: [UDev Backend] Narrow device queried for

This revision was automatically updated to reflect the committed changes. Closed by commit R245:fe1c9c02e09f: [UDev Backend] Narrow device queried for (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21379?vs=59052=59253 REVISION DETAIL

D21379: [UDev Backend] Narrow device queried for

bruns accepted this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow device queried for

bruns added a comment. In D21379#475032 , @broulik wrote: > Ping :) > > In D21379#472870 , @bruns wrote: > > > The question now is, should we also differnentiate here, i.e. map `QVariant()` to

D21379: [UDev Backend] Narrow device queried for

broulik added a comment. Ping :) In D21379#472870 , @bruns wrote: > The question now is, should we also differnentiate here, i.e. map `QVariant()` to `nullptr`, and use `"*"` for wildcards? What do you mean? REPOSITORY R245

D21379: [UDev Backend] Narrow device queried for

broulik updated this revision to Diff 59052. broulik edited the test plan for this revision. broulik added a comment. - Use `*` wildcard REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21379?vs=58850=59052 REVISION DETAIL https://phabricator.kde.org/D21379

D21379: [UDev Backend] Narrow device queried for

bruns added a comment. In D21379#472418 , @broulik wrote: > For some reason here my `udev_enumerate_add_match_property("ID_MEDIA_PLAYER", null)` doesn't work. If I check for "1" it works but `null` doesn't find any devices. Since the systemd

D21379: [UDev Backend] Narrow device queried for

broulik added a comment. For some reason here my `udev_enumerate_add_match_property("ID_MEDIA_PLAYER", null)` doesn't work. If I check for "1" it works but `null` doesn't find any devices. Since the systemd code uses `fnmatch`, we can probably just pass `*` to it to match anything.

D21379: [UDev Backend] Narrow device queried for

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. I just reverted it as it indeed causes problems with initial device lookup. Not just in plasmashell but also in Dolphin. Since Frameworks tagging is tomrrow, better leave it for now and

D21379: [UDev Backend] Narrow device queried for

ngraham added a task: T10958: Faster Startup. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow device queried for

This revision was automatically updated to reflect the committed changes. Closed by commit R245:079b2bc91cb2: [UDev Backend] Narrow device queried for (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21379?vs=58839=58850 REVISION DETAIL

D21379: [UDev Backend] Narrow device queried for

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > broulik wrote in udevqtclient.cpp:223 > This is just copied from the other code. I can fixup all of them separately > later if you want. Yes, thats completely fine for

D21379: [UDev Backend] Narrow device queried for

broulik updated this revision to Diff 58839. broulik retitled this revision from "[UDev Backend] Narrow subsystems queried for cameras" to "[UDev Backend] Narrow device queried for". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a