D21427: Always skip trailing slashes in FilderedDirIterator

2019-07-14 Thread Igor Poboiko
poboiko added a comment. In D21427#494174 , @bruns wrote: > In D21427#494010 , @poboiko wrote: > > > Ping! > > > > Apparently, it does fix bug 409257, which is pretty serious one (db

D21427: Always skip trailing slashes in FilderedDirIterator

2019-07-11 Thread Stefan BrĂ¼ns
bruns added a comment. In D21427#494010 , @poboiko wrote: > Ping! > > Apparently, it does fix bug 409257, which is pretty serious one (db corruption, after all). The DB corruption is already fixed in KF5.60. REPOSITORY R293 Baloo

D21427: Always skip trailing slashes in FilderedDirIterator

2019-07-11 Thread Igor Poboiko
poboiko added a comment. Ping! Apparently, it does fix bug 409257, which is pretty serious one (db corruption, after all). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21427 To: poboiko, #frameworks, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n,

D21427: Always skip trailing slashes in FilderedDirIterator

2019-07-11 Thread Igor Poboiko
poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21427 To: poboiko, #frameworks, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D21427: Always skip trailing slashes in FilderedDirIterator

2019-06-30 Thread Igor Poboiko
poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21427 To: poboiko, #frameworks, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D21427: Always skip trailing slashes in FilderedDirIterator

2019-06-30 Thread Igor Poboiko
poboiko added a reviewer: ngraham. poboiko added a comment. Not entirely sure, but bug 409257 might be caused by that (at least in my case, it looked the same). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21427 To:

D21427: Always skip trailing slashes in FilderedDirIterator

2019-06-28 Thread Igor Poboiko
poboiko added a comment. Ping. I've found a way to reproduce a related issue: $ mkdir ~/test $ balooctl config add includeFolders ~/test $ balooctl stop $ balooctl start This prints an error: replace called with invalid arguments, docId: url: "~/test/"

D21427: Always skip trailing slashes in FilderedDirIterator

2019-05-27 Thread Igor Poboiko
poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21427 To: poboiko, #frameworks, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21427: Always skip trailing slashes in FilderedDirIterator

2019-05-27 Thread Igor Poboiko
poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21427 To: poboiko, #frameworks, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21427: Always skip trailing slashes in FilderedDirIterator

2019-05-27 Thread Igor Poboiko
poboiko created this revision. poboiko added reviewers: Frameworks, Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY I've encountered weird regression. Here is the description: