D21466: Recommend rebooting after installing Samba

This revision was automatically updated to reflect the committed changes. Closed by commit R432:8a104aa4fb41: Recommend rebooting after installing Samba (authored by ngraham). REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE

D21466: Recommend rebooting after installing Samba

sitter edited the summary of this revision. REPOSITORY R432 File Sharing (Samba) integration BRANCH recommend-rebooting (branched from master) REVISION DETAIL https://phabricator.kde.org/D21466 To: ngraham, #vdg, #frameworks, #dolphin, apol, sitter Cc: anthonyfieroni, sitter, bruns

D21466: Recommend rebooting after installing Samba

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R432 File Sharing (Samba) integration BRANCH recommend-rebooting (branched from master) REVISION DETAIL https://phabricator.kde.org/D21466 To: ngraham, #vdg, #frameworks, #dolphin, apol, sitter Cc:

D21466: Recommend rebooting after installing Samba

anthonyfieroni added a comment. Just start services, reboot will not do anything else. REPOSITORY R432 File Sharing (Samba) integration REVISION DETAIL https://phabricator.kde.org/D21466 To: ngraham, #vdg, #frameworks, #dolphin, apol Cc: anthonyfieroni, sitter, bruns

D21466: Recommend rebooting after installing Samba

apol added a comment. In D21466#626419 , @sitter wrote: > In D21466#625834 , @apol wrote: > > > So yes, Discover will notify about updates. That doesn't mean it should be shown here too. > > >

D21466: Recommend rebooting after installing Samba

sitter added a comment. In D21466#625834 , @apol wrote: > So yes, Discover will notify about updates. That doesn't mean it should be shown here too. To clarify: are you -1 this diff? > If anything, we should be pushing for such

D21466: Recommend rebooting after installing Samba

apol added a comment. So yes, Discover will notify about updates. That doesn't mean it should be shown here too. If anything, we should be pushing for such updates to happen at startup/shutdown because it doesn't seem like the user benefits from it being swapped at runtime, but that's

D21466: Recommend rebooting after installing Samba

sitter added inline comments. INLINE COMMENTS > ngraham wrote in sambausershareplugin.h:63 > Yes, but I'd prefer to do that in another patch and port all the inline > messages at once. Ah! There's more. Fine with me then. REPOSITORY R432 File Sharing (Samba) integration REVISION DETAIL

D21466: Recommend rebooting after installing Samba

ngraham added inline comments. INLINE COMMENTS > sitter wrote in sambausershareplugin.h:63 > shouldn't this rather be a KMessageWidget? As I recall we usually use KMWs > for this type of notification. Yes, but I'd prefer to do that in another patch and port all the inline messages at once.

D21466: Recommend rebooting after installing Samba

sitter added a comment. random comment: since we install through polkit the distro should deal with this. polkit can report whether a reboot is necessary, and discover has support for that, so in theory if a distro/polkit backend reports it as necessary (because they added a new group), it

D21466: Recommend rebooting after installing Samba

ngraham added a comment. In D21466#471371 , @bruns wrote: > In D21466#471325 , @ngraham wrote: > > > In D21466#471321 , @bruns wrote: > > > > > For

D21466: Recommend rebooting after installing Samba

bruns added a comment. In D21466#471325 , @ngraham wrote: > In D21466#471321 , @bruns wrote: > > > For group membership changes, only a relogin is required (at most). > > > I know, but telling

D21466: Recommend rebooting after installing Samba

ngraham added a comment. In D21466#471321 , @bruns wrote: > For group membership changes, only a relogin is required (at most). I know, but telling people to log out and log back in again involves more ways to mess up than just telling

D21466: Recommend rebooting after installing Samba

bruns added a comment. For group membership changes, only a relogin is required (at most). The only relevant group membership here is the usershare group, which can be determined from the owner/group of the "usershare path = " directory (samba config). If the user can write to the

D21466: Recommend rebooting after installing Samba

ngraham updated this revision to Diff 58801. ngraham added a comment. Revert unintentional whitespace change REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21466?vs=58800=58801 BRANCH recommend-rebooting (branched from master)

D21466: Recommend rebooting after installing Samba

ngraham created this revision. ngraham added reviewers: VDG, Frameworks, Dolphin, apol. ngraham requested review of this revision. REVISION SUMMARY After Samba is installed, very frequently it will not work correctly until the machine is rebooted. One potential reason is when the installed