D21533: Format photo exposure time and bias as rational

astippich updated this revision to Diff 59222. astippich added a comment. - add unit REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21533?vs=59221=59222 BRANCH photo_time REVISION DETAIL https://phabricator.kde.org/D21533 AFFECTED FILES

D21533: Format photo exposure time and bias as rational

astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:167 > For a chart of typical exposure times, see > https://www.borrowlenses.com/blog/shutter-speed-chart/ > > I can confirm for my Canon SLR there is at one more value which would give a > deviating result,

D21533: Format photo exposure time and bias as rational

astippich updated this revision to Diff 59221. astippich added a comment. - only format exposure time REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21533?vs=59028=59221 BRANCH photo_time REVISION DETAIL https://phabricator.kde.org/D21533

D21533: Format photo exposure time and bias as rational

bruns added inline comments. INLINE COMMENTS > astippich wrote in formatstrings.cpp:167 > I changed the threshold to be lower than that as a workaround. > My impression was that only 1 over something rationals are used, this > computation will of course fail for all other cases... For a chart

D21533: Format photo exposure time and bias as rational

astippich planned changes to this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21533 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:167 > This will give a wrong result (1/2) for 0.4 seconds. I changed the threshold to be lower than that as a workaround. My impression was that only 1 over something

D21533: Format photo exposure time and bias as rational

astippich updated this revision to Diff 59028. astippich added a comment. - implement feedback REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21533?vs=59009=59028 BRANCH photo_time REVISION DETAIL https://phabricator.kde.org/D21533 AFFECTED

D21533: Format photo exposure time and bias as rational

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21533 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D21533: Format photo exposure time and bias as rational

bruns added inline comments. INLINE COMMENTS > propertyinfotest.cpp:134 > +{ Property::PhotoExposureTime, true, 0.0015625, > QStringLiteral("1/640")}, > +{ Property::PhotoExposureBiasValue, true, 0.333, > QStringLiteral("1/3")}, >

D21533: Format photo exposure time and bias as rational

astippich updated this revision to Diff 59009. astippich added a comment. - check for zero REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21533?vs=59004=59009 BRANCH photo_time REVISION DETAIL https://phabricator.kde.org/D21533 AFFECTED FILES

D21533: Format photo exposure time and bias as rational

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21533 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

astippich added a comment. Ideally it would be possible to store rationals in KFM and Baloo, but this is probably a lot of work. The computation here is quite simple REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21533 To: astippich, bruns, ngraham Cc:

D21533: Format photo exposure time and bias as rational

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY If value is below 0.5, format the output as rational which