davidedmundson abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D21618
To: davidedmundson, #plasma, apol
Cc: broulik, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
davidedmundson planned changes to this revision.
davidedmundson added a comment.
Will make new and improved version
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D21618
To: davidedmundson, #plasma, apol
Cc: broulik, apol, kde-frameworks-devel,
broulik added inline comments.
INLINE COMMENTS
> appletinterface.cpp:172
>
> -applet()->updateConstraints(Plasma::Types::UiReadyConstraint);
> +if (m_loadingRef == 0) {
> +applet()->updateConstraints(Plasma::Types::UiReadyConstraint);
In my case this code path is hit before
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Thought about it a bit more, it should be okay.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21618
To: davidedmundson, #plasma,
apol added a comment.
I wonder if that's the right API to use from QML, I guess it's fine but
marking something as successful by assigning null could feel odd?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D21618
To: davidedmundson, #plasma
Cc:
apol added a dependent revision: D21619: Wallpaper: delay calling UIReady until
the image is actually loaded.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D21618
To: davidedmundson, #plasma
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh,
apol added a comment.
+1 LGTM
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D21618
To: davidedmundson, #plasma
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Plasma applets when they were all C++ had a way for them to
