brute4s99 updated this revision to Diff 59551.
brute4s99 added a comment.
fixed indentation
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21660?vs=59376=59551
BRANCH
simplify (branched from master)
REVISION DETAIL
apol added a comment.
I'd say you're not simplifying it, you're changing the logic. This needs to
be reflected in the commit message.
INLINE COMMENTS
> CMakeLists.txt:93
> endif()
> endif()
> +endif()
indentation is wrong.
REPOSITORY
R289 KNotifications
REVISION DETAIL
nicolasfella added inline comments.
INLINE COMMENTS
> CMakeLists.txt:42
> +else ()
> +find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus)
> endif()
We don't need DBus on Windows, do we?
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D21660
To:
brute4s99 added a dependency: D21657: remove phonon from deps if building for
win32.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D21660
To: brute4s99, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
brute4s99 retitled this revision from "simplify conditions" to "simplify
conditions and remove audio dependency for win32".
brute4s99 edited the summary of this revision.
brute4s99 added a reviewer: broulik.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D21660
