This revision was automatically updated to reflect the committed changes.
Closed by commit R293:4fcbfee9b669: [ModifiedFileIndexer] Use correct mimetype
for folders, delay until needed (authored by bruns).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
astippich accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21706
To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh,
astippich,
bruns marked an inline comment as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21706
To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh,
astippich, spoorun, ngraham, bruns, abrahams
bruns updated this revision to Diff 59564.
bruns marked an inline comment as done.
bruns added a comment.
update comment
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21706?vs=59470=59564
REVISION DETAIL
https://phabricator.kde.org/D21706
AFFECTED FILES
astippich added inline comments.
INLINE COMMENTS
> modifiedfileindexer.cpp:82
> +if (fileInfo.isDir()) {
> +// The folder ctime changes when the file is created, when the
> folder is
> +// renamed, or when the xattrs (tags, comments, ...) change
"when the folder
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> poboiko wrote in modifiedfileindexer.cpp:68
> Does it also changes behavior of ModifiedFileIndexer? What happened to
> symlinks before?
It depends on the state of the PendingFileQueue:
- when an item is not
poboiko added inline comments.
INLINE COMMENTS
> modifiedfileindexer.cpp:68
> QFileInfo fileInfo(filePath);
> -
> -// A folders mtime is updated when a new file is added / removed /
> renamed
> -// we don't really need to reindex a folder when that happens
> -//
bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
mimeTypeForFile is quite expensive (much more than
