D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64465. leinir added a comment. - Use the image's Ready status, rather than just the url availability REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=64426=64465 BRANCH knsquick-feature-parity-with-kns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64426. leinir added a comment. - Switch to a slightly different avatar display method - Rejig the lamdba slightly, with less indirection (and more working) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64413. leinir added a comment. - Work up the NewStuffItem layout a touch... - Less explicit layouting (and more QtLayouts) - Re-enable use of the (now more usable) score from the comments model REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 63107. leinir added a comment. - Use typed animations instead of the inefficient PropertyAnimation REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=62850=63107 BRANCH knsquick-feature-parity-with-kns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62850. leinir added a comment. - Parent the QuickQuestionAsker to qApp - Add in a QuestionAsker on NewStuffList REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=62846=62850 BRANCH

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62846. leinir added a comment. - Fix up the NewStuffItem installer busy indicator a bit REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=62844=62846 BRANCH knsquick-feature-parity-with-kns (branched from

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62844. leinir added a comment. - Add in a getter for category displaynames - Add category/filter/sort dropdowns to NewStuffList - A bit of minor prettification for NewStuffItem REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62785. leinir added a comment. - Actually request a downloaditem in NewStuffItem when install/updating REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=62049=62785 BRANCH knsquick-feature-parity-with-kns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62049. leinir added a comment. - Refactor the naming of components etc a touch (and hide private bits) - Fix a few bits of stray naming in the docs REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=61905=62049

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61905. leinir added a comment. - Don't use outdated code (e.g. the Kirigami Label component) - Update NewStuffList to the new model API - Explicit operator= implementations (for less warnings) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61638. leinir added a comment. - A small spacer item for the entry details page - Documentation++ - Show a passive notification in the dialog when messages are posted REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61500. leinir added a comment. - Add a downloaditemssheet to the entry details page REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=61341=61500 BRANCH knsquick-feature-parity-with-kns (branched from master)

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61341. leinir added a comment. - Put the NewStuff.Author component to use on the details page as well REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=61340=61341 BRANCH knsquick-feature-parity-with-kns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61340. leinir added a comment. - Add the user ID to the author class - Expose the entry author id through the qtquick item model - Rename the entryAuthor property to entryAuthorId, as that's what it is - Add a bit more info to the author - Add a

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61331. leinir added a comment. Thanks kbroulik! - allowedByKiosk should be a CONSTANT property, as it's... constant - Postpone engine initialisation until Button is clicked REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61065. leinir added a comment. - Add profile page to the author classes - Add a spacer item to the CommentsPage listview - A touch of visual cleaning in the comment delegate - Type-safe comparisons are good - Throttle the fetch calls just a touch,

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60920. leinir added a comment. - Uncrash the author hash (don't use const QString references as key...) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=60781=60920 BRANCH knsquick-feature-parity-with-kns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60781. leinir added a comment. Bunch of work on the comments (especially avatar stuff). In progress, of course, but the concept is there - Add an Author component to the QtQuick bits - Add Providers functionality for fetching person data - Add

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60729. leinir added a comment. - Work on the comments delegate's look some REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=60689=60729 BRANCH knsquick-feature-parity-with-kns (branched from master)

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60689. leinir added a comment. - Fill the width in the dialog's sidebar with Button - Use the knsrc file's Name attr for title (already translated) - Indent the comments by their depth (this is imperfect, but...) REPOSITORY R304 KNewStuff CHANGES

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60214. leinir added a comment. Address anthonyfieroni's comment about manual memory management in the comments fetching system - Switch to a shared_ptr list for comments (less manual memory mgmnt) REPOSITORY R304 KNewStuff CHANGES SINCE LAST

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

anthonyfieroni added a comment. QList should be QList>, don't leave ownership to consumers. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60204. leinir added a comment. - Sort the default sizing on the Dialog to be more pleasant - Rejig the Dialog's button implementation, so it's now got shortcuts - Set the default column width of the test dialog REPOSITORY R304 KNewStuff CHANGES

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60181. leinir added a comment. - A pile of style cleaning - Implement the adoptItem function in KNSQuick::ItemsModel REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=60052=60181 BRANCH

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60052. leinir marked 2 inline comments as done. leinir added a comment. Address pino's comments about BIC (and some documentation) - Don't mark functions virtual which should not be virtual - Apply the signal/slot virt func workaround for improved

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked 2 inline comments as done. leinir added inline comments. INLINE COMMENTS > pino wrote in engine.h:471 > BIC change, you cannot add virtual functions in a public class That shouldn't be virtual anyway, not sure why i did that... > pino wrote in provider.h:148 > BIC change, you

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

pino added inline comments. INLINE COMMENTS > engine.h:471 > + */ > +virtual CommentsModel* commentsForEntry(const KNSCore::EntryInternal > ); > + BIC change, you cannot add virtual functions in a public class > provider.h:148 > virtual void loadPayloadLink(const EntryInternal ,

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60021. leinir added a comment. Highlights: NewStuffButton, basic Kiosk support (needs more clever and user-facing mention of why the thing they just tried to do didn't happen/do anything), various fixing, cleanup, and sanity work. - Fix logic for

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. In D21721#478676 , @ngraham wrote: > Could the new one be API compatible so we wouldn't need to wait for KF6? Also it's always nice to avoid breaking API if you don't have to. Not entirely sure we can do that, the

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

ngraham added a comment. Could the new one be API compatible so we wouldn't need to wait for KF6? Also it's always nice to avoid breaking API if you don't have to. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir Cc: ngraham, kde-frameworks-devel,

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. In D21721#478241 , @ngraham wrote: > Thanks! I think we should definitely aim to replace the old QWidgets-based one. Otherwise we're signing up for an increased maintenance burden with no real advantages IMO. Consider

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

ngraham added a comment. Thanks! I think we should definitely aim to replace the old QWidgets-based one. Otherwise we're signing up for an increased maintenance burden with no real advantages IMO. Consider that we already have the GHNS dialog as well as Discover's UI, and each one has

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. In D21721#477397 , @ngraham wrote: > How does one test this? By running the khotnewstuff-dialog application and passing a knsrc file to it (though i would point to the first line in the summary for the moment

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

ngraham added a comment. How does one test this? Does it replace the existing one? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Basic KNewStuffQuick dialog for testing purposes Actually return the number of comments, not the rating Change