D21830: Format photo exposure bias value

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0a042beb5568: Format photo exposure bias value (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21830?vs=59875=60265 REVISION DETAIL

D21830: Format photo exposure bias value

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH exposure_bias REVISION DETAIL https://phabricator.kde.org/D21830 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,

D21830: Format photo exposure bias value

astippich added a comment. friendly ping, would be great to get this in before the string freeze REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21830 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,

D21830: Format photo exposure bias value

astippich updated this revision to Diff 59875. astippich added a comment. - remove unnecessary else REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21830?vs=59874=59875 BRANCH exposure_bias REVISION DETAIL https://phabricator.kde.org/D21830

D21830: Format photo exposure bias value

bruns added inline comments. INLINE COMMENTS > formatstrings.cpp:193 > +return i18nc("Exposure bias/compensation in exposure value (EV)", > "%1 EV", locale.toString(val, 'g', 3)); > +} else { > +int integral = roundedSixthParts / 6; no need for else here, you return. dito

D21830: Format photo exposure bias value

astippich updated this revision to Diff 59874. astippich added a comment. - remove unneeded newline REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21830?vs=59873=59874 BRANCH exposure_bias REVISION DETAIL https://phabricator.kde.org/D21830

D21830: Format photo exposure bias value

astippich marked an inline comment as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21830 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

astippich updated this revision to Diff 59873. astippich added a comment. - cover 1/2 case REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21830?vs=59870=59873 BRANCH exposure_bias REVISION DETAIL https://phabricator.kde.org/D21830 AFFECTED

D21830: Format photo exposure bias value

astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:183 > You obviously multiply here ... dividing by one third is multiplying by three :) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21830 To: astippich, bruns, ngraham Cc:

D21830: Format photo exposure bias value

bruns added inline comments. INLINE COMMENTS > formatstrings.cpp:183 > +auto val = value.toDouble(); > +// exposure values are in steps of one third, divide by it > +auto thirds = val * 3; You obviously multiply here ... REPOSITORY R286 KFileMetaData REVISION DETAIL

D21830: Format photo exposure bias value

bruns added a comment. In D21830#480185 , @astippich wrote: > In D21830#480181 , @bruns wrote: > > > Many cameras can be switched to 1/2 EV steps. > > > Damn ;) do you know any other values?

D21830: Format photo exposure bias value

astippich added a comment. In D21830#480181 , @bruns wrote: > Many cameras can be switched to 1/2 EV steps. Damn ;) do you know any other values? In case not, I would add this case in a loop and stupidly try everything REPOSITORY R286

D21830: Format photo exposure bias value

bruns added a comment. Many cameras can be switched to 1/2 EV steps. INLINE COMMENTS > formatstrings.cpp:189 > +int wholeNumber = roundedThirds / 3; > +if (wholeNumber > 0) { > +return i18nc("Exposure compensation given in thirds, with whole > number, in exposure

D21830: Format photo exposure bias value

astippich added a comment. exposure bias seems mostly to be in steps of 1/3 according to https://www.geofflawrence.com/exposure_compensation.html REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21830 To: astippich, bruns, ngraham Cc: kde-frameworks-devel,

D21830: Format photo exposure bias value

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Format the photo exposure bias value in EV units and in