D21907: Show feedback inline when creating new files or folders

dhaumann added a comment. So it boils down to "let's try this and improve later if necessary" - well then :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf, meven Cc: filipf, squeakypancakes, dhaumann, aacid,

D21907: Show feedback inline when creating new files or folders

ngraham added a comment. In D21907#484197 , @dhaumann wrote: > These two points were not discussed anymore: I addressed them in https://phabricator.kde.org/D21907#482181: > 1. Isn't there a better solution by creating the folder and

D21907: Show feedback inline when creating new files or folders

dhaumann added a comment. These two points were not discussed anymore: 1. Isn't there a better solution by creating the folder and immediately select it + change to edit mode? 2. Resizing dialogs are usually not preferred. If everyone else thinks this change is a good idea - then

D21907: Show feedback inline when creating new files or folders

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4fb959b910bf: Show feedback inline when creating new files or folders (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21907?vs=60299=60329

D21907: Show feedback inline when creating new files or folders

meven accepted this revision. meven added a comment. This is look good to me ! REPOSITORY R241 KIO BRANCH better-new-file-folder-info (branched from master) REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf, meven Cc: filipf,

D21907: Show feedback inline when creating new files or folders

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH better-new-file-folder-info (branched from master) REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf Cc: filipf, squeakypancakes, dhaumann, aacid, meven,

D21907: Show feedback inline when creating new files or folders

ngraham added inline comments. INLINE COMMENTS > meven wrote in knewfilemenu.cpp:1099 > Shouldn't we disable the ok button here ? No, because this isn't an error condition (it's just a warning). > meven wrote in knewfilemenu.cpp:1122 > Same here No, because this isn't an error condition (it's

D21907: Show feedback inline when creating new files or folders

ngraham updated this revision to Diff 60299. ngraham marked 4 inline comments as done. ngraham added a comment. Disable Ok button for all error conditions (but not for warning conditions) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21907?vs=60137=60299

D21907: Show feedback inline when creating new files or folders

meven added inline comments. INLINE COMMENTS > knewfilemenu.cpp:1099 > +m_messageWidget->setMessageType(KMessageWidget::Information); > +m_messageWidget->animatedShow(); > +} Shouldn't we disable the ok button here ? > knewfilemenu.cpp:1109 > +

D21907: Show feedback inline when creating new files or folders

ngraham added a comment. If there are no formal objections, I'd like to land this. REPOSITORY R241 KIO BRANCH better-new-file-folder-info (branched from master) REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf Cc: filipf,

D21907: Show feedback inline when creating new files or folders

ngraham updated this revision to Diff 60137. ngraham added a comment. This revision is now accepted and ready to land. - Do the right thing on Windows - Don't show any warnings when creating filenames with slashes in them (KIO currently allows it but substitutes a different character)

D21907: Show feedback inline when creating new files or folders

ngraham planned changes to this revision. ngraham added a comment. Going to better handle Windows and also fix a bug that slipped in. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf Cc: filipf, squeakypancakes,

D21907: Show feedback inline when creating new files or folders

ngraham added a comment. Any more comments? REPOSITORY R241 KIO BRANCH better-new-file-folder-info (branched from master) REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf Cc: filipf, squeakypancakes, dhaumann, aacid, meven,

D21907: Show feedback inline when creating new files or folders

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Looks good from a visual and usability POV. REPOSITORY R241 KIO BRANCH better-new-file-folder-info (branched from master) REVISION DETAIL https://phabricator.kde.org/D21907 To:

D21907: Show feedback inline when creating new files or folders

ngraham added a comment. In D21907#482146 , @dhaumann wrote: > The much better fix would be: create the folder "New Folder" inline in the list view and immediately switch to edit mode, this way you do not need a dialog at all but don't loose

D21907: Show feedback inline when creating new files or folders

squeakypancakes added a comment. Do the warnings need to below the buttons? I feel like they are kinda out of place there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham Cc: squeakypancakes, dhaumann, aacid, meven,

D21907: Show feedback inline when creating new files or folders

ngraham added a comment. The gif depicts a rather extreme case where you're deliberately trying to test all the feedback modes in quick succession. :) At @meven's request, I've already removed the red error message when the text field is empty. REPOSITORY R241 KIO REVISION DETAIL

D21907: Show feedback inline when creating new files or folders

dhaumann added a comment. Have not looked at the patch, just the gif: I am rather sceptical if instant feedback is a good idea here. First, having an empty line edit will happen a lot, usually without the user wanting to press OK. That means the user will already get feedback in the middle

D21907: Show feedback inline when creating new files or folders

aacid added inline comments. INLINE COMMENTS > meven wrote in knewfilemenu.cpp:1071 > What about Windows ? maybe use QDir::separator() ? read the docu for QDir::separator() , you seldom ever want to use it. https://agateau.com/2015/qdir-separator-considered-harmful/ REPOSITORY R241 KIO

D21907: Show feedback inline when creating new files or folders

ngraham added a comment. In D21907#482087 , @meven wrote: > It made me think about D17595 . > Would it make sense to upstream this to KIO and unify behavior with Open/Save Dialog (it currently has a folder

D21907: Show feedback inline when creating new files or folders

meven added a comment. It made me think about D17595 . Would it make sense to upstream this to KIO and unify behavior with Open/Save Dialog (it currently has a folder name check using popups). This is a different matter so it should not stop progress

D21907: Show feedback inline when creating new files or folders

ngraham updated this revision to Diff 60079. ngraham marked an inline comment as done. ngraham added a comment. Don't show an ugly error when the text field is blank REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21907?vs=60072=60079 BRANCH

D21907: Show feedback inline when creating new files or folders

meven added inline comments. INLINE COMMENTS > knewfilemenu.cpp:1047 > +if (text.length() == 0) { > +m_messageWidget->setText(i18n("Name cannot be blank.")); > +m_messageWidget->setMessageType(KMessageWidget::Error); I would rather disable the ok button, as long as the user

D21907: Show feedback inline when creating new files or folders

ngraham created this revision. ngraham added reviewers: VDG, Frameworks, shubham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now, the new file/folder dialog allows you to give it an