This revision was automatically updated to reflect the committed changes.
Closed by commit R39:42c64e1e081c: Make automatic spellcheck work after
reloading a document (authored by ahmadsamir, committed by cullmann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
ahmadsamir added a comment.
Great :). Please commit it too (as I don't have access to kde git).
REPOSITORY
R39 KTextEditor
BRANCH
document-reloaded-spellcheck (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21940
To: ahmadsamir, #ktexteditor, cullmann, dhaumann
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me now :)
REPOSITORY
R39 KTextEditor
BRANCH
document-reloaded-spellcheck (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21940
To: ahmadsamir,
ahmadsamir marked 5 inline comments as done.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D21940
To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh,
ngraham, bruns, demsking, cullmann,
ahmadsamir updated this revision to Diff 60467.
ahmadsamir removed a subscriber: dhaumann.
ahmadsamir added a comment.
Use a lambda instead of adding a standalone method
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21940?vs=60154=60467
BRANCH
dhaumann added inline comments.
INLINE COMMENTS
> ahmadsamir wrote in ontheflycheck.cpp:75
> In file included from /usr/include/qt5/QtCore/qalgorithms.h:43,
>from /usr/include/qt5/QtCore/qlist.h:43,
>from /usr/include/qt5/QtCore/QList:1,
>
ahmadsamir added a comment.
Qt docs say that the signal must have at least as many arguments as the slot,
and there is an implicit conversion between the types of the corresponding
arguments in the signal and the slot.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
ahmadsamir added inline comments.
INLINE COMMENTS
> dhaumann wrote in ontheflycheck.cpp:75
> But refreshSpellCheck() has a default parameter, so this function exists
> without any parameter. Afaik this should work?!
In file included from /usr/include/qt5/QtCore/qalgorithms.h:43,
dhaumann added inline comments.
INLINE COMMENTS
> ahmadsamir wrote in ontheflycheck.cpp:75
> That wouldn't work, reloaded() takes a Document pointer parameter whereas
> refreshSpellcheck takes a Range parameter.
But refreshSpellCheck() has a default parameter, so this function exists
without
ahmadsamir added inline comments.
INLINE COMMENTS
> dhaumann wrote in ontheflycheck.cpp:75
> Directly connect to this, refreshSpellCheck.
That wouldn't work, reloaded() takes a Document pointer parameter whereas
refreshSpellcheck takes a Range parameter.
REPOSITORY
R39 KTextEditor
REVISION
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
You don't need the extra function. Could you update the patch?
INLINE COMMENTS
> ontheflycheck.cpp:75
>
> +connect(document, ::Document::reloaded,
> +this,
sars added a comment.
LGTM
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D21940
To: ahmadsamir, #ktexteditor, cullmann
Cc: sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh,
ngraham, bruns, demsking, cullmann, dhaumann
ahmadsamir created this revision.
ahmadsamir added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
When a document gets reloaded for whatever reason, automatic spellcheck
should be refreshed so as to
13 matches
Mail list logo
