D22102: Implement apply-on-double-click for all grid view KCM delegates

2021-04-30 Thread Nathaniel Graham
ngraham abandoned this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22102 To: ngraham, #plasma, #vdg, mart, broulik Cc: ndavis, anthonyfieroni, pino, davidedmundson, filipf, mglb, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-07-05 Thread Nathaniel Graham
ngraham added a comment. In D22102#488774 , @mglb wrote: > In D22102#487806 , @ngraham wrote: > > > use its hidden Alt accelerator. > > > Looks like already working solution for the problem.

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-07-01 Thread David Edmundson
davidedmundson added a comment. > Exposing the options through a simple command line interface would be another option. At the risk of getting offtopic, it's the reason I started the KConfigWatcher class. The intention being for "kwriteconfig" to be used generically and then anything

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-30 Thread Mariusz Glebocki
mglb added a comment. In D22102#487806 , @ngraham wrote: > use its hidden Alt accelerator. Seems like already working solution for the problem. Whats wrong with alt accelerator? REPOSITORY R296 KDeclarative REVISION DETAIL

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-30 Thread Nathaniel Graham
ngraham added a comment. I don't really know what else to say. The current workflow is annoying and slow for me and I want to improve it. Maybe this isn't the best way, but it's rather frustrating to come up against a wall of opposition doubting whether it's a problem at all, or if it is,

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-30 Thread Noah Davis
ndavis added a comment. In D22102#487806 , @ngraham wrote: > Maybe I should move back and examine the rationale for the proposal. > > Right now, I find it *extremely* annoying, slow, and frustrating to test new themes, colors, icons,

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-30 Thread Pino Toscano
pino added a comment. In D22102#488447 , @ngraham wrote: > In D22102#488388 , @pino wrote: > > > While I can understand that clicking can be "annoying", OTOH I consider all the KCMs you mentioned as

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-30 Thread Nathaniel Graham
ngraham added a comment. In D22102#488388 , @pino wrote: > While I can understand that clicking can be "annoying", OTOH I consider all the KCMs you mentioned as "mostly once" configuration items: you generally configure the

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-30 Thread Anthony Fieroni
anthonyfieroni added a comment. Alternatively you can add message widget that explore double click functionality, when double click is applied it can change its message that save is applied. But rater OK/Apply became a bit pointless. REPOSITORY R296 KDeclarative REVISION DETAIL

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-30 Thread Pino Toscano
pino added a comment. In D22102#487806 , @ngraham wrote: > Right now, I find it *extremely* annoying, slow, and frustrating to test new themes, colors, icons, wallpapers, etc. The workflow is to click on the delegate, and then click on the

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-28 Thread Nathaniel Graham
ngraham added a comment. Maybe I should move back and examine the rationale for the proposal. Right now, I find it *extremely* annoying, slow, and frustrating to test new themes, colors, icons, wallpapers, etc. The workflow is to click on the delegate, and then click on the Apply button

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-26 Thread Pino Toscano
pino added a comment. In D22102#486968 , @davidedmundson wrote: > From the old review: > > pino: > > -1 for this: > > hidden feature > it does not make sense when the general paradigm is OK/Apply/Cancel, so we are

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-26 Thread David Edmundson
davidedmundson added a comment. From the old review: pino: -1 for this: hidden feature it does not make sense when the general paradigm is OK/Apply/Cancel, so we are teaching users that options are applied only when OK/Apply is pressed (and thus they are left

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-26 Thread Filip Fila
filipf added a comment. Generally +1, but let's disable it for destructive kcms. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22102 To: ngraham, #plasma, #vdg, mart, broulik Cc: filipf, mglb, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-26 Thread Mariusz Glebocki
mglb added a comment. > Look-and-feel User accidentally doubleclicks item and all their look-related settings are gone. Has to configure everything again. > Splash Screen User accidentally doubleclicks item, nothing visible happens, gets suprised on next login. Since the

D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-26 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, VDG, mart, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This is a better-implemented alternative to D18571