mweichselbaumer closed this revision.
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D22107
To: mweichselbaumer, drosca
Cc: ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
mweichselbaumer added inline comments.
INLINE COMMENTS
> drosca wrote in tpendingcall.h:45
> Alright, that makes sense.
>
> With KF6 we can convert all PendingCalls to this form. It would be a good
> idea to add `TODO: KF6` somewhere to not forget it.
Ok, i will update this patch and land it
drosca accepted this revision.
drosca added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> mweichselbaumer wrote in tpendingcall.h:45
> Actually, my intention was to provide a type-safe way to obtain return values
> from PendingCall and to express
mweichselbaumer added inline comments.
INLINE COMMENTS
> ltoscano wrote in a2dp-codecs.h:33
> Will it work with older versions of bluez?
Bluez just defines this constant, but does not use it internally (nor we do).
So, yes, this works with any version of bluez.
REPOSITORY
R269 BluezQt
ltoscano added inline comments.
INLINE COMMENTS
> mweichselbaumer wrote in a2dp-codecs.h:33
> Yes, this has also been fixed by bluez as of 2018-12-28.
Will it work with older versions of bluez?
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D22107
To:
mweichselbaumer marked an inline comment as done.
mweichselbaumer added inline comments.
INLINE COMMENTS
> drosca wrote in a2dp-codecs.h:33
> Are you sure about this?
Yes, this has also been fixed by bluez as of 2018-12-28.
> drosca wrote in tpendingcall.h:45
> Is this really needed? In the
drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> a2dp-codecs.h:33
> #define A2DP_CODEC_MPEG240x02
> -#define A2DP_CODEC_ATRAC 0x03
> +#define A2DP_CODEC_ATRAC 0x04
>
mweichselbaumer added a reviewer: drosca.
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D22107
To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
mweichselbaumer created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mweichselbaumer requested review of this revision.
REPOSITORY
R269 BluezQt
BRANCH
mediatransport
REVISION DETAIL
https://phabricator.kde.org/D22107
AFFECTED FILES
