D22144: Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 62417. meven added a comment. Remove the current option to filter on curent application as it does not work REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=62298&id=62417 BRANCH arcpatch-D22144 REVISION DET

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven added a dependent revision: D7446: [Places panel] Revamp the Recently Saved section. REPOSITORY R320 KIO Extras BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprc

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 62298. meven added a comment. Disallow getting mimetype or stating non root path REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=61929&id=62298 BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.k

D22144: Add kio recentlyused:/ to access KactivitytStats data

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R320 KIO Extras BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-framework

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven marked 6 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, mic

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 61929. meven added a comment. Fix typos, missing space... REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=61860&id=61929 BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED

D22144: Add kio recentlyused:/ to access KactivitytStats data

ngraham added a comment. Indeed, it was a database issue. Looks like that's on kactivitymanagerd, not you! It's probably too late to get this into 19.08 unfortunately. In my experience big new features like this shouldn't be merged right before the deadline. In addition to the inlin

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven added a comment. In D22144#496414 , @ngraham wrote: > So interestingly enough, accessing `recentlyused:/` in Dolphin's URL navigator works great, but doing `recentlyused:/?limit=100` causes it to crash on an assert: > > $ dolphin >

D22144: Add kio recentlyused:/ to access KactivitytStats data

ngraham added a comment. So interestingly enough, accessing `recentlyused:/` in Dolphin's URL navigator works great, but doing `recentlyused:/?limit=100` causes it to crash on an assert: $ dolphin org.kde.kactivities.lib.core: Setting the title: "" ASSERT: "!name.isEmpty()" in

D22144: Add kio recentlyused:/ to access KactivitytStats data

ngraham added a comment. Aha, that was the fix that made it work for me! Thanks a bunch. I will conduct a more thorough review soon. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-de

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven added a comment. @ngraham I just fixed an issue in the recentlyused.json file, this should work much easier. I encounter some instabilities with kactivitiymanagerd. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngr

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 61860. meven added a comment. Fix json file REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=60886&id=61860 BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES CMake

D22144: Add kio recentlyused:/ to access KactivitytStats data

ngraham added a comment. Thanks, got it built. However unfortunately it didn't help. I see that `/home/nate/kde/usr/lib64/plugins/kf5/kio/recentlyused.so` exists, and `/home/nate/kde/usr/lib64/plugins` is in my `$QT_PLUGIN_PATH` variable. And yet... $ KDE_FORK_SLAVE=1 /home/nate/k

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven added a comment. In D22144#495277 , @ngraham wrote: > I wonder if this is the problem: > > ls /home/nate/kde/usr/bin/kioclient5 > ls: cannot access '/home/nate/kde/usr/bin/kioclient5': No such file or directory > > > What ac

D22144: Add kio recentlyused:/ to access KactivitytStats data

ngraham added a comment. I wonder if this is the problem: ls /home/nate/kde/usr/bin/kioclient5 ls: cannot access '/home/nate/kde/usr/bin/kioclient5': No such file or directory What actually builds that binary? My KIO doesn't seem to do it. REPOSITORY R320 KIO Extras REVISIO

D22144: Add kio recentlyused:/ to access KactivitytStats data

meven retitled this revision from "- Add kio recentlyused:/ to access KactivitytStats data" to "Add kio recentlyused:/ to access KactivitytStats data". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, k

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven added a comment. In D22144#490974 , @ngraham wrote: > Nice! > > What's the right way to apply this patch? Using the instructions in the text plan section, I'm not able to get it to work: > > ~/kde/src/kio-extras $ (arcpatch-D2214

D22144: - Add kio recentlyused:/ to access KactivitytStats data

ngraham added a comment. Nice! What's the right way to apply this patch? Using the instructions in the text plan section, I'm not able to get it to work: ~/kde/src/kio-extras $ (arcpatch-D22144) kb Total of 'trivial' dependency cycles detected & eliminated: 2 Building

D22144: - Add kio recentlyused:/ to access KactivitytStats data

elvisangelaccio added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, nava

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven added a comment. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, f

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 60886. meven marked an inline comment as done. meven added a comment. New json metadata file REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=60789&id=60886 BRANCH master REVISION DETAIL https://phabricato

D22144: - Add kio recentlyused:/ to access KactivitytStats data

elvisangelaccio added inline comments. INLINE COMMENTS > recentlyused.protocol:1-14 > +[Protocol] > +X-DocPath=kioslave5/recentlyused/index.html > +exec=kf5/kio/recentlyused > +protocol=recentlyused > +Icon=document-open-recent > +input=none > +output=filesystem We should use the JSON format for

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, fi

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales,

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 60789. meven added a comment. Improve declared protocol REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=60788&id=60789 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES CM

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 60788. meven added a comment. Remove default debug option sevirity at debug REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=60787&id=60788 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22144

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven created this revision. meven added reviewers: ivan, Frameworks, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Prior to finish D7446