D22155: Add new activities and virtual desktops icons

dfaure added a comment. Thanks! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: dfaure, anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. In D22155#527004 , @dfaure wrote: > This commit introduced dangling symlinks, detected by `make` and the CI. > > warning: failed to load external entity "./icons-dark/status/symbolic/content-loading-symbolic.svg" >

D22155: Add new activities and virtual desktops icons

dfaure added a comment. This commit introduced dangling symlinks, detected by `make` and the CI. warning: failed to load external entity "./icons-dark/status/symbolic/content-loading-symbolic.svg" warning: failed to load external entity

D22155: Add new activities and virtual desktops icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b5261c6e3b69: Add new activities and virtual desktops icons (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22155?vs=60836=65532 REVISION

D22155: Add new activities and virtual desktops icons

ngraham added a comment. And in fact it was. :( Looks like that was a typo on the wiki, and 5.62 is the correct one. Feel free to land this right now. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL

D22155: Add new activities and virtual desktops icons

ngraham added a comment. Guh, I guess the schedule changed. I could have sworn that 5.52 was the original frameworks dependency target. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. Actually, it is Frameworks 5.63 that releases on October 12, in time for 5.17 which releases on October 15. I guess I'll need to wait another month. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION

D22155: Add new activities and virtual desktops icons

ngraham added a comment. Cool! Consider this a pre-approval to land this at the appropriate time, then. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. In D22155#491783 , @ngraham wrote: > Frameworks 5.60 has been tagged, so this would end up in 5.61 if it lands now. I kind of think we should wait one more month and land it for 5.62 so it's perfectly aligned with Plasma

D22155: Add new activities and virtual desktops icons

ngraham added a comment. Frameworks 5.60 has been tagged, so this would end up in 5.61 if it lands now. I kind of think we should wait one more month and land it for 5.62 so it's perfectly aligned with Plasma 5.17. Are you okay with that? REPOSITORY R266 Breeze Icons BRANCH

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. Ping REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n,

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. In D22155#488981 , @anthonyfieroni wrote: > +1 to be part of Plasma 5.17 Wouldn't my proposed approach be better? Also, only one patch out of many actually affects Plasma. In D22155#488595

D22155: Add new activities and virtual desktops icons

anthonyfieroni added a comment. In D22155#488593 , @ngraham wrote: > In D22155#488485 , @anthonyfieroni wrote: > > > Renaming the icon is not quite good, if someone use newer framework and old

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. In D22155#488593 , @ngraham wrote: > In D22155#488485 , @anthonyfieroni wrote: > > > Renaming the icon is not quite good, if someone use newer framework and old applications /

D22155: Add new activities and virtual desktops icons

ngraham added a comment. In D22155#488485 , @anthonyfieroni wrote: > Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new

D22155: Add new activities and virtual desktops icons

anthonyfieroni added a comment. In D22155#488497 , @GB_2 wrote: > We can backport the changes in Plasma to the LTS branch though. We can backport but you cannot increase depends on 5.60 to the LTS branch. So it should have a fallback

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. Phew, done! REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg,

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22173: [kactivities] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: anthonyfieroni, ngraham,

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22172: [kio-extras] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: anthonyfieroni, ngraham,

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. In D22155#488485 , @anthonyfieroni wrote: > Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new

D22155: Add new activities and virtual desktops icons

anthonyfieroni added a comment. Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new features + bugs fix and Plasma offers LTS. REPOSITORY R266 Breeze Icons BRANCH

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22171: [colord-kde] Use more appropriate icon, because the activities icon changed. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2,

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22170: [latte-dock] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22167: [plasma-workspace] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22168: [plasma-desktop] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22169: [plasma-active-window-control] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc:

D22155: Add new activities and virtual desktops icons

ngraham added a comment. +1, please mark this patch as a dependency for the other patches and then let's land 'em all together once everything looks good. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL

D22155: Add new activities and virtual desktops icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I'm accepting this, but make sure you don't land this until you've submitted the other patches. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. In D22155#488192 , @ndavis wrote: > Nice job! > > Are there other patches coming soon to fix the code where `preferences-activities` was used? Yeah, I'll make them soon. REPOSITORY R266 Breeze Icons REVISION

D22155: Add new activities and virtual desktops icons

ndavis added a comment. Nice job! Are there other patches coming soon to fix the code where `preferences-activities` was used? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n,

D22155: Add new activities and virtual desktops icons

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY This adds new monochrome icons corresponding to the colorful ones. Also deletes the old