D22216: RFC: Use wayland-protocols

2019-07-03 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. It's the technically correct thing to do. > Generally, I see nothing wrong with waiting until protocol foo becomes part of the current wayland-protocols release. The problem there is that then we're not giving pro

D22216: RFC: Use wayland-protocols

2019-07-03 Thread Roman Gilg
romangg accepted this revision. romangg added a subscriber: davidedmundson. romangg added a comment. This revision is now accepted and ready to land. Yea, let's wait until 5.60 branched and then push for 5.61 (after next weekend) as long as @davidedmundson does not say anything against it unti

D22216: RFC: Use wayland-protocols

2019-07-03 Thread Vlad Zagorodniy
zzag added a comment. Also, it's worth to point out that neither weston, nor Mutter, nor wlroots copy protocol specs, they just have wayland-protocols as a dependency. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22216 To: zzag, #kwin, #frameworks Cc: apol, roma

D22216: RFC: Use wayland-protocols

2019-07-03 Thread Vlad Zagorodniy
zzag added a comment. Generally, I see nothing wrong with waiting until protocol foo becomes part of the current wayland-protocols release. If the protocol is really importatnt, we can make temporary copy and after several kwayland releases drop it. REPOSITORY R127 KWayland REVISION DETAI

D22216: RFC: Use wayland-protocols

2019-07-03 Thread Vlad Zagorodniy
zzag added a comment. > Why was it done differently until now? I can't give you an answer, but my guess is for historical reasons. Initially, kwayland repo had only proprietary protocols, like server_decoration, etc. Protocols from wayland-protocols were copied to follow the pattern. Al

D22216: RFC: Use wayland-protocols

2019-07-02 Thread Aleix Pol Gonzalez
apol added a comment. Big +1. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22216 To: zzag, #kwin, #frameworks Cc: apol, romangg, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22216: RFC: Use wayland-protocols

2019-07-02 Thread Roman Gilg
romangg added a comment. Makes sense to me. Why was it done differently until now? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22216 To: zzag, #kwin, #frameworks Cc: romangg, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22216: RFC: Use wayland-protocols

2019-07-02 Thread Vlad Zagorodniy
zzag added a reviewer: Frameworks. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22216 To: zzag, #kwin, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22216: RFC: Use wayland-protocols

2019-07-02 Thread Vlad Zagorodniy
zzag added a comment. > find_package(WaylandProtocols 1.15) because xdg-decoration was introduced in 1.15. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22216 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22216: RFC: Use wayland-protocols

2019-07-02 Thread Vlad Zagorodniy
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY So far we've been copying protocol specifications from wayland-protocols repo to kwayland repo.