D22419: Fix cant enter directory error on Android FTP servers

2019-07-19 Thread NXiss7
nxiss7 updated this revision to Diff 62067. nxiss7 edited the summary of this revision. nxiss7 added a comment. Fixed comment. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22419?vs=61647=62067 REVISION DETAIL https://phabricator.kde.org/D22419 AFFECTED FILES

D22419: Fix cant enter directory error on Android FTP servers

2019-07-19 Thread NXiss7
nxiss7 edited the summary of this revision. nxiss7 edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22419: Fix cant enter directory error on Android FTP servers

2019-07-16 Thread Albert Astals Cid
aacid added a comment. Why is uppercase only better compatibility if the spec clearly says that case doesn't matter ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron,

D22419: Fix cant enter directory error on Android FTP servers

2019-07-16 Thread NXiss7
nxiss7 added a comment. Instead of sending another command, should we refactor all FTP commands to upper case for better compatibility (as suggested by muesli) ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: svuorela,

D22419: Fix cant enter directory error on Android FTP servers

2019-07-16 Thread Ben Cooksley
bcooksley changed the visibility from "All Users" to "Public (No Login Required)". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22419: Fix cant enter directory error on Android FTP servers

2019-07-15 Thread NXiss7
nxiss7 changed the visibility from "Public (No Login Required)" to "All Users". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22419: Fix cant enter directory error on Android FTP servers

2019-07-15 Thread NXiss7
nxiss7 added a comment. ES File Manager 3.2.5 has this issue. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22419: Fix cant enter directory error on Android FTP servers

2019-07-15 Thread NXiss7
nxiss7 added a comment. You're right. But some applications don't work well. I think this would make KIO more "works out of the box" and help end-user... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: svuorela,

D22419: Fix cant enter directory error on Android FTP servers

2019-07-15 Thread Sune Vuorela
svuorela added a comment. According to the RFC, the server should ignore case: > Upper and lower case alphabetic characters are to be treated > identically. Thus any of the following may represent the retrieve > command: > > RETR Retr retr ReTr rETr I'm not sure how many

D22419: Fix cant enter directory error on Android FTP servers

2019-07-12 Thread NXiss7
nxiss7 edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22419: Fix cant enter directory error on Android FTP servers

2019-07-12 Thread NXiss7
nxiss7 added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22419: Fix cant enter directory error on Android FTP servers

2019-07-12 Thread NXiss7
nxiss7 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nxiss7 requested review of this revision. REVISION SUMMARY Some Android FTP server applications don't implement lower-case "list" command thus KIO can't connect to server and fail