D22477: Add a config to only show completions matching word beginning

2019-07-16 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 61879. ahmadsamir added a comment. Change the diff altogether to not show the menu with "ContainsMatch" REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22477?vs=61807&id=61879 BRANCH less-trigger-happy-completio

D22477: Add a config to only show completions matching word beginning

2019-07-16 Thread Sven Brauch
brauch added a comment. I'm not sure if this solves the right problem. Where I notice this issue a lot is when typing "return". The keyword completion suggests "return", and when I want a newline, I complete the "return" first. This doesn't affect C++ (because of the trailing ";"), but i

D22477: Add a config to only show completions matching word beginning

2019-07-16 Thread Ahmad Samir
ahmadsamir added a comment. In D22477#496059 , @kossebau wrote: > Default is `false,` so does not change behaviour unless someone toggles the switch, right? > > I would rename the option to `WordCompletionMatchFromWordStartOnly` though, as f

D22477: Add a config to only show completions matching word beginning

2019-07-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. Default is `false,` so does not change behaviour unless someone toggles the switch, right? I would rename the option to `WordCompletionMatchFromWordStartOnly` though, as from what I can tell completion often only does from start, and matching also in the word i

D22477: Add a config to only show completions matching word beginning

2019-07-15 Thread Christoph Cullmann
cullmann added reviewers: KDevelop, kossebau, mwolff, kfunk. cullmann added a comment. Given KDevelop uses the completion a lot more extensive than Kate, I would like to have some input from there, too ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To:

D22477: Add a config to only show completions matching word beginning

2019-07-15 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This disables the current behaviour where if no match is found, completions that "contain" the