D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22502 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

poboiko added a comment. In D22502#496812 , @bruns wrote: > The correct fix is to check the returned/calculated ID in the IndexCleaner, otherwise its racy. I think both can be implemented. I had in mind the case when folder was

D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22502 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov,

D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

bruns added a comment. The correct fix is to check the returned/calculated ID in the IndexCleaner, otherwise its racy. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22502 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron,

D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

poboiko created this revision. poboiko added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. poboiko requested review of this revision. REVISION SUMMARY It is possible to create an invalid entry inside includedFolders, for example: by creating some folder, adding