D22528: KIO FTP: Fix file copy hanging when copying to existing file

fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R241

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun abandoned this revision. ZaWertun added a comment. No problem. I'm closing revision then. Thanks for the feedback. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: ngraham, rikmills, kde-frameworks-devel,

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. Well, we *could* land it, I am also not sure if that is a net-improvement though. As David said we are playing ping-pong with bugs and all of them are symptoms of the larger issue that error handling is done inconsistently, which in turn is why fixing one bug causes

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ngraham added a comment. > but sure, whatever, if you think it's better with this commit than with the earlier equally broken two versions, I'm not objecting. @sitter so what do you think, should we land this in the meantime? REPOSITORY R241 KIO REVISION DETAIL

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. Just found another bug on the KDE bugzilla related to this: https://bugs.kde.org/show_bug.cgi?id=410357. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: rikmills, kde-frameworks-devel, LeGast00n,

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. In D22528#507373 , @dfaure wrote: > Is your work on a proper two-classes solution not ready? Nope, I haven't made any progress on it beyond what I posted. I briefly looked at a testing setup to make sure stuff

D22528: KIO FTP: Fix file copy hanging when copying to existing file

dfaure added a comment. I can't say if this is better in or out, since it's broken in any case. We're playing ping-pong with broken code, but sure, whatever, if you think it's better with this commit than with the earlier equally broken two versions, I'm not objecting. Is your work on

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. @dfaure are we ok to land this for now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: rikmills, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. Wrong. Still present in KF frameworks 5.61: KIO’s FTP connection feature is now more tolerant of broken FTP server implementations (Enes Selim, KDE Frameworks 5.61) (from https://pointieststick.com/2019/07/28/kde-usability-productivity-week-81/)

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. Bug still present in plasma 5.16.4. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: rikmills, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22528: KIO FTP: Fix file copy hanging when copying to existing file

dfaure added a comment. I like very much your proposal about using two classes to avoid reintroducing problems in the future. I like a lot less the use of exceptions, generally speaking... one uncaught exception and it's the end of the world. But OK I see that in this case, there is a

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. Something like this https://phabricator.kde.org/P439 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. Hm. I've had a quick look and I think the intent was that only the slavebase overridden functions call error or finished. So technically all internal functions that can have an error need to set an iError or return one so that the "public" function can then issue

D22528: KIO FTP: Fix file copy hanging when copying to existing file

dfaure added a comment. Please wait. This is a partial revert of my earlier commit to this file -- not exactly, but it feels like there is a bit of a mess regarding the question of whether error() was already emitted or not. I made the assumption that statusServerError meant error was

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. In D22528#497803 , @sitter wrote: > Looks good to me. The slave indeed must issue an exit state there. > > What email address would you like to have associated with the git commit? zawer...@gmail.com

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Looks good to me. The slave indeed must issue an exit state there. What email address would you like to have associated with the git commit? REPOSITORY R241 KIO REVISION DETAIL

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. Patch was made against version 5.60.0 (rev 8513ca9 ). Sorry that I didn't mention it earlier. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun,

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ngraham added a reviewer: cfeck. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ngraham retitled this revision from "KIO FTP: File copy hangs when copying to existing file - fix" to "KIO FTP: Fix file copy hanging when copying to existing file". ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: