D22653: Add view-qrcode icons

2019-07-24 Thread Mathis Brüchert
mbruchert updated this revision to Diff 62460. mbruchert added a comment. rename to view-barcode-qr as suggeste REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62346&id=62460 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2265

D22653: Add view-qrcode icons

2019-07-22 Thread Noah Davis
ndavis added a comment. In D22653#500427 , @mbruchert wrote: > The blue corners are supposed to indicate that the QR-Code can be scanned. But aren't QR codes normally scannable? REPOSITORY R266 Breeze Icons REVISION DETAIL https://p

D22653: Add view-qrcode icons

2019-07-22 Thread Noah Davis
ndavis added a comment. In D22653#500471 , @broulik wrote: > How about `view-barcode-qr`? then we could potentially have specific `view-barcode-aztec` and also a fallback to `view-barcode` +1 REPOSITORY R266 Breeze Icons REVISION DETA

D22653: Add view-qrcode icons

2019-07-22 Thread Kai Uwe Broulik
broulik added a comment. How about `view-barcode-qr`? then we could potentially have specific `view-barcode-aztec` and also a fallback to `view-barcode` REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis Cc: broulik, ndavis, kd

D22653: Add view-qrcode icons

2019-07-22 Thread Mathis Brüchert
mbruchert added a comment. The blue corners are supposed to indicate that the QR-Code can be scanned. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

D22653: Add view-qrcode icons

2019-07-22 Thread Mathis Brüchert
mbruchert updated this revision to Diff 62346. mbruchert added a comment. Add icons to breeze-dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62344&id=62346 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653 AFFECTED F

D22653: Add view-qrcode icons

2019-07-22 Thread Mathis Brüchert
mbruchert updated this revision to Diff 62344. mbruchert added a comment. Remove accidentially committed changes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62343&id=62344 BRANCH master REVISION DETAIL https://phabricator.kde.org/D226

D22653: Add view-qrcode icons

2019-07-22 Thread Mathis Brüchert
mbruchert updated this revision to Diff 62343. mbruchert added a comment. Optimize and use css theme colors REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62318&id=62343 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653 A

D22653: Add view-qrcode icons

2019-07-22 Thread Noah Davis
ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Noah Davis
ndavis added a comment. Hi! Thanks for the patch. There are few things I'd like you to change before I accept this. The icons need optimization and colorscheme support (see workflow tips). If you have questions or need help, feel free to ask. 16px version: The margins are a pixel

D22653: Add view-qrcode icons

2019-07-22 Thread Mathis Brüchert
mbruchert added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

2019-07-22 Thread Mathis Brüchert
mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653 AFFECTED FILES icons/actions/1