D23207: Fixing implementation of FileJob interface in smb/sftp slaves

This revision was automatically updated to reflect the committed changes. Closed by commit R320:28fdc41f1d45: Fixing implementation of FileJob interface in smb/sftp slaves (authored by feverfew). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

bcooksley removed a subscriber: fsitter. REPOSITORY R320 KIO Extras BRANCH fixSFTP (branched from master) REVISION DETAIL https://phabricator.kde.org/D23207 To: feverfew, chinmoyr, fvogt, sitter, dfaure Cc: bcooksley, kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n,

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R320

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R320

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R320

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

sitter added a comment. @dfaure this is actually a different beast altogether, the current state validation is only run on the API for all slaves, seek/read/write are run in a completely different loop which I see isn't being verified at all. I'll add it in a separate diff once the

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

dfaure added a comment. OK, I'm wrong, it doesn't check that at the moment. But IIRC your slavebase patch does that meanwhile ;) REPOSITORY R320 KIO Extras BRANCH fixSFTP (branched from master) REVISION DETAIL https://phabricator.kde.org/D23207 To: feverfew, chinmoyr, fvogt, sitter,

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Well I guess these fixes came to be exactly *because* SlaveBase warns about finished() being called when it shouldn't :-) REPOSITORY R320 KIO Extras BRANCH fixSFTP (branched from

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

sitter added a comment. SlaveBase (which the slaves derive from) runs a command loop, out of this command loop come the actual calls to the API functions. So, in said command loop we can verify which state the slave is in before and more importantly after any API call. Specifically about

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

feverfew added a comment. In D23207#520233 , @sitter wrote: > Not knowing the background here at a glance I would argue that SlaveBase in KIO should be getting state verification on all of this,. Sorry, I'm not sure what you mean by

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

sitter added a comment. Not knowing the background here at a glance I would argue that SlaveBase in KIO should be getting state verification on all of this,. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23207 To: feverfew, chinmoyr, fvogt, sitter, dfaure Cc:

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

feverfew added reviewers: sitter, dfaure. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23207 To: feverfew, chinmoyr, fvogt, sitter, dfaure Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

feverfew updated this revision to Diff 63876. feverfew added a comment. Unnecessary min version upgraded REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23207?vs=63875=63876 BRANCH fixSFTP (branched from master) REVISION DETAIL

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

feverfew retitled this revision from "Fixing finished() called after error() in smb slave. Do not call finished() in open/read/write/seek operations" to "Fixing implementation of FileJob interface in smb/sftp slaves". feverfew edited the summary of this revision. feverfew edited the test plan