This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:f0bdbcbf982f: Add FictionBook 2 icons (authored by
yurchor).
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST
ndavis accepted this revision.
ndavis added a comment.
LGTM
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23300
To: yurchor, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
yurchor updated this revision to Diff 64286.
yurchor added a comment.
Use black "fb" for 32px and 64px breeze-dark
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23300?vs=64281=64286
BRANCH
master
REVISION DETAIL
ndavis added a comment.
Much better. There is only one thing left that I think should be done for 32
and 64 px. Rather than having a black "fb" for Breeze and and a white "fb" for
Breeze Dark, use either white for both with a drop shadow under the "fb" or
just black for both and no drop
yurchor updated this revision to Diff 64281.
yurchor added a comment.
Realign 32px versions, replace 16px and 22px with icons proposed by Noah
Davis, add dark versions
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23300?vs=64236=64281
BRANCH
yurchor reclaimed this revision.
yurchor added a comment.
This revision now requires changes to proceed.
Unexpected free time.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23300
To: yurchor, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel,
yurchor abandoned this revision.
yurchor added a comment.
I have no time to redo this now. Sorry.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23300
To: yurchor, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.
Upon closer inspection, I found a few issues that need to be fixed.
Blur can't be used because the Qt SVG renderer doesn't support it. You'll
have to use linear or radial
yurchor updated this revision to Diff 64236.
yurchor added a comment.
Optimize SVG with svgcleaner + svgo
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23300?vs=64212=64236
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23300
ndavis added a comment.
Reduce the size of the SVGs by optimizing them with one of these tools:
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23300
To: yurchor, #vdg, ngraham
ngraham added a subscriber: ndavis.
ngraham added a comment.
LGTM. @ndavis?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23300
To: yurchor, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
yurchor updated this revision to Diff 64212.
yurchor added a comment.
Use blue background
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23300?vs=64206=64212
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23300
AFFECTED FILES
yurchor edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23300
To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
ngraham added a comment.
Haha that pink might be a bit too un-brutalist. :) Orange-on-pink isn't
exactly the best color combination. A blue background of some sort might be
nicer with the orange polygon.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23300
yurchor updated this revision to Diff 64206.
yurchor added a comment.
Total unbrutalization
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23300?vs=64186=64206
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23300
AFFECTED FILES
yurchor edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23300
To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
ngraham added a comment.
Better, thanks! Any chance you could make the gray background color a bit
different? Maybe lighter, or some other color? That particular gray isn't a
very attractive color IMO. It's very brutalist. :)
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
yurchor edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23300
To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
yurchor updated this revision to Diff 64186.
yurchor added a comment.
Be consistent with existing book-style icons.
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23300?vs=64152=64186
BRANCH
master
REVISION DETAIL
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Interesting design! However having that triangular part jutting out of the
side is pretty unusual, and not seen in any other MimeType icons. Maybe move
that shape fully inside
yurchor updated this revision to Diff 64152.
yurchor added a comment.
Remove extra font dependencies
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23300?vs=64148=64152
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23300
AFFECTED
yurchor edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23300
To: yurchor, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
yurchor created this revision.
yurchor added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
yurchor requested review of this revision.
REVISION SUMMARY
FictionBook 2 icons from Okular (design by Vladimir Prohorenkov, my
implementation).
23 matches
Mail list logo
