D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b97ce61950c9: Add support for handling QNAM SSL errors to KSslErrorUiData (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23323?vs=64233=65061#toc REPOSITORY R241 KIO

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ktcpsocket.h:416 > +/** > + * Create an instance and initialize it with SSL error data from @p > reply. > + */ @since 5.62 REPOSITORY R241 KIO BRANCH

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

vkrause added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23323 To: vkrause, #frameworks, dfaure Cc: dhaumann, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

vkrause added a comment. In D23323#519093 , @dhaumann wrote: > In D23323#516317 , @apol wrote: > > > Makes sense, but I feel some explanation is missing ^^' > > > > Put it in the commit message?

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

dhaumann added a comment. In D23323#516317 , @apol wrote: > Makes sense, but I feel some explanation is missing ^^' > > Put it in the commit message? Better: put it into the API documentation? REPOSITORY R241 KIO REVISION DETAIL

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

vkrause added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23323 To: vkrause, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

vkrause edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23323 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

apol added a comment. Makes sense, but I feel some explanation is missing ^^' Put it in the commit message? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23323 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23323 AFFECTED FILES src/core/ktcpsocket.cpp