D23348: force applicationDirPath into first position when finding plugins

2019-08-22 Thread David Faure
dfaure added a comment. Yep, as documented in https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23348 To: sitter, mpyne, dfaure Cc: cullmann, kde-frameworks-devel, LeGast00n, GB_2,

D23348: force applicationDirPath into first position when finding plugins

2019-08-22 Thread Harald Sitter
sitter added a comment. That is a solvable problem, there's a property to control where things end up in the build tree: `set_target_properties(kio_ftp PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/kf5/kio")` REPOSITORY R244 KCoreAddons REVISION DETAIL

D23348: force applicationDirPath into first position when finding plugins

2019-08-22 Thread Christoph Cullmann
cullmann added a comment. ;=) Yeah, all ugly. Even with the above code btw. an uninstalled Kate would still not find the plugins as it wants them in some "ktexteditor" subdir in plugins but with the current CMake setup they will end in the build directory in directly the same dir as the

D23348: force applicationDirPath into first position when finding plugins

2019-08-22 Thread Harald Sitter
sitter added a comment. Perhaps the answer actually is that QT_PLUGIN_PATH should not be necessary ;) This is a bit of a chicken and egg problem. When our software can't find plugins automatically we resort to QT_PLUGIN_PATH, but then because we use QT_PLUGIN_PATH we can't just break it

D23348: force applicationDirPath into first position when finding plugins

2019-08-22 Thread Christoph Cullmann
cullmann added a comment. Yes, I have some review request that does something similar inside Kate and I am not sure that this would help us either. https://invent.kde.org/kde/kate/merge_requests/8 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23348 To:

D23348: force applicationDirPath into first position when finding plugins

2019-08-22 Thread Harald Sitter
sitter abandoned this revision. sitter added a comment. Agh, you are very right of course. Things are never easy :/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23348 To: sitter, mpyne, dfaure Cc: cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23348: force applicationDirPath into first position when finding plugins

2019-08-22 Thread Christoph Cullmann
cullmann added a comment. Hmm, I don't think this is a good thing to do. e.g. look at this setup: You have some globally installed Kate/KDevelop/... You develop a plugin, it is already shipped with the global install by the distro. You compile locally your plugin and setup

D23348: force applicationDirPath into first position when finding plugins

2019-08-22 Thread Harald Sitter
sitter created this revision. sitter added reviewers: mpyne, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY applicationDirPath technically is already part of libraryPaths BUT it's position