D23420: Use solid to check if a KFileItem is located on a network mount

meven abandoned this revision. meven added a comment. Abandoned in favor of D26407 using KMountPoint which does close to the same thing as solid. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks

D23420: Use solid to check if a KFileItem is located on a network mount

bruns added a comment. Solid should be quite fine. When queried for devices providing 'Solid::DeviceInterface::NetworkShare', it will only use the fstab backend, which does not block and only reparses fstab/mtab when these change. There are some unnecessary QString constructions in the

D23420: Use solid to check if a KFileItem is located on a network mount

dfaure added a comment. Heh, yeah, we have 3 APIs about mounted filesystems. Solid, KMountPoint, and KFileSystemType. KFileSystemType uses the blocking statvfs, while KMountPoint relies on a properly filled in /etc/fstab -- which breaks on the FreeBSD CI these days, some weird magic

D23420: Use solid to check if a KFileItem is located on a network mount

meven added a comment. I didn't know about `KMount` Gwenview uses it as we are trying here : bool urlIsFastLocalFile(const QUrl ) { if (!url.isLocalFile()) { return false; } KMountPoint::List list = KMountPoint::currentMountPoints();

D23420: Use solid to check if a KFileItem is located on a network mount

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > broulik wrote in kfileitem.cpp:766 > If you have a location `/home/foo/foobar` and a slow mount `/home/foo/foo`, > it will consider it slow because "starts

D23420: Use solid to check if a KFileItem is located on a network mount

broulik added a comment. > isSlow() didn't check linkDest before. Even more reason to do it properly now :P `KFileSystemType` uses `statfs`. I didn't find any documentation on whether it follows symlinks, but it is documented to return an `ELOOP` error code "Too many symbolic links

D23420: Use solid to check if a KFileItem is located on a network mount

meven marked an inline comment as done. meven added a comment. In D23420#519949 , @broulik wrote: > Now we still need the `linkDest` check :) isSlow() didn't check linkDest before. REPOSITORY R241 KIO BRANCH arcpatch-D23420

D23420: Use solid to check if a KFileItem is located on a network mount

meven updated this revision to Diff 64716. meven added a comment. Add a const& clean unused variable REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23420?vs=64715=64716 BRANCH arcpatch-D23420 REVISION DETAIL https://phabricator.kde.org/D23420 AFFECTED

D23420: Use solid to check if a KFileItem is located on a network mount

anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kfileitem.cpp:764 > Get it as `const Solid::StorageAccess`, you can use `auto storageAccess = ...` Let clarify what David mean for (const Solid::Device& device : devices) { auto storageAccess = device.as();

D23420: Use solid to check if a KFileItem is located on a network mount

broulik added a comment. Now we still need the `linkDest` check :) REPOSITORY R241 KIO BRANCH arcpatch-D23420 REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23420: Use solid to check if a KFileItem is located on a network mount

meven updated this revision to Diff 64715. meven added a comment. better check file path REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23420?vs=64645=64715 BRANCH arcpatch-D23420 REVISION DETAIL https://phabricator.kde.org/D23420 AFFECTED FILES

D23420: Use solid to check if a KFileItem is located on a network mount

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D23420 REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

ngraham retitled this revision from "Use solid to check if a a KFileItem is located on a network mount" to "Use solid to check if a KFileItem is located on a network mount". REPOSITORY R241 KIO BRANCH solid-network-fs-check REVISION DETAIL https://phabricator.kde.org/D23420 To: meven,