D23537: extend state verification to open connection commands

2019-10-23 Thread Harald Sitter
sitter abandoned this revision. sitter added a comment. Replaced by D24887 which instead creates a more generic system to verify slave behavior. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23537 To: sitter, dfaure Cc: fsitter,

D23537: extend state verification to open connection commands

2019-10-21 Thread Harald Sitter
sitter added a comment. I've actually started work on a more general system for this. Will update soon. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23537 To: sitter, dfaure Cc: fsitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23537: extend state verification to open connection commands

2019-10-21 Thread Harald Sitter
sitter planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23537 To: sitter, dfaure Cc: fsitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23537: extend state verification to open connection commands

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R241

D23537: extend state verification to open connection commands

2019-08-28 Thread Harald Sitter
sitter added a comment. I do wonder if maybe it would make sense to revise the verification system to be based off of a list of allowed/forbidden functions that may be called during a command. e.g. for open the requirements are actually more complicated than this diff establishes. It

D23537: extend state verification to open connection commands

2019-08-28 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY - open/seek/read/write: may not call finished (only error) - close: must reach