sitter updated this revision to Diff 67695.
sitter marked 24 inline comments as done.
sitter added a comment.
- rebase
- ftpSendCmd now returns a bool (continues to require_result)
- openConnection now emits opened()
- listDir now finalize()s
- debug--
- ftpSendCmd's lazy login now
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ftp.cpp:2153
> +const auto storResult = ftpOpenCommand("stor", dest, '?',
> ERR_CANNOT_WRITE, offset);
> +qDebug() << "!!! storresult" << storResult;
sitter edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23579
To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ngraham, bruns
sitter added inline comments.
INLINE COMMENTS
> dfaure wrote in ftptest.cpp:186
> what's bad quot?
>
> Is this test about a bug, or the job failing is what we want?
That was meant to read quota. I've changed it to QVERIFY(!job->exec()); as per
your earlier comment.
> dfaure wrote in
sitter updated this revision to Diff 66747.
sitter marked 31 inline comments as done.
sitter added a comment.
address numerous comments (marked done on phab)
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23579?vs=64989=66747
BRANCH
ftp
REVISION DETAIL
pino added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in ftp.h:49
> That's BIC we cannot remove, reorder nor insert parent(s)
> That's BIC we cannot remove, reorder nor insert parent(s)
This is a kioslave, built as plugin. There is no such thing as BC for this kind
of stuff.
anthonyfieroni added inline comments.
INLINE COMMENTS
> ftp.h:49
>
> //===
> -class Ftp : public QObject, public KIO::SlaveBase
> {
That's BIC we cannot remove, reorder nor insert parent(s)
> ftp.h:167
> +
> +class
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Nice work!
INLINE COMMENTS
> ftptest.cpp:33
> +public:
> +QUrl url(const QString )
> +{
this method should be const
> ftptest.cpp:50
> +// works around the fact
sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
This system is a bit inspired by an earlier patch I threw together in
a half hour to prevent the actual logic code from
