D23685: Make user-trash icons look like trashcans

Codezela added a comment. I think they looks different The shadow on the empty one make it looks very flat Or maybe squashed The full state looks better REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23685 To: ndavis, #vdg, ngraham Cc: Codezela, ngraham,

D23685: Make user-trash icons look like trashcans

This revision was automatically updated to reflect the committed changes. Closed by commit R266:d970e61493a6: Make user-trash icons look like trashcans (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23685?vs=65268=65322 REVISION

D23685: Make user-trash icons look like trashcans

ndavis added a comment. In D23685#525085 , @ngraham wrote: > Actually, that's a great point. The current red appearance is indeed a constant annoyance to me and makes me want to keep it empty all the time, which, now that I think about it,

D23685: Make user-trash icons look like trashcans

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Actually, that's a great point. The current red appearance is indeed a constant annoyance to me and makes me want to keep it empty all the time, which, now that I think about it, defeats

D23685: Make user-trash icons look like trashcans

ndavis added a comment. In D23685#525072 , @ngraham wrote: > In D23685#524935 , @ndavis wrote: > > > > Before, the red folder background made it instantly recognizable that the trash was full--even

D23685: Make user-trash icons look like trashcans

ngraham added a comment. In D23685#524935 , @ndavis wrote: > > Before, the red folder background made it instantly recognizable that the trash was full--even if this wasn't really an appropriate visual metaphor. I wonder if we could play with

D23685: Make user-trash icons look like trashcans

ndavis added a comment. In D23685#524775 , @ngraham wrote: > Yay real trashcans The appearance is definitely more appropriate compared to before. I really like it. > > However I'm afraid the visual recognizability of the full state

D23685: Make user-trash icons look like trashcans

ngraham added a comment. Yay real trashcans The appearance is definitely more appropriate compared to before. I really like it. However I'm afraid the visual recognizability of the full state compared to the empty state is worsened compared to the status quo: Empty: F7310762:

D23685: Make user-trash icons look like trashcans

ndavis updated this revision to Diff 65268. ndavis added a comment. Add breeze dark icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23685?vs=65267=65268 BRANCH trash (branched from master) REVISION DETAIL https://phabricator.kde.org/D23685

D23685: Make user-trash icons look like trashcans

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23685 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23685: Make user-trash icons look like trashcans

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23685 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23685: Make user-trash icons look like trashcans

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY BUG: 399613 REPOSITORY R266 Breeze Icons BRANCH trash (branched from master)