D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

This revision was automatically updated to reflect the committed changes. Closed by commit R320:52175ce07389: Add two special cases url recentlyused:/files and recentlyused:/folders (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven added a comment. The /folders path is /locations in fact REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe,

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 67102. meven added a comment. Correct ?type use with /files : ?type overrules /files, since they are aggregated with ORs REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65959=67102 BRANCH arcpatch-D23742

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ngraham added a comment. Please do! It's already accepted. :) REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe,

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven marked 2 inline comments as done. meven added a comment. I will land this soonish if no one has any objections. REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel,

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65959. meven added a comment. Allow users to use ?type filter with /files path REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65597=65959 BRANCH arcpatch-D23742 REVISION DETAIL

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ngraham added inline comments. INLINE COMMENTS > meven wrote in recentlyused.cpp:98 > Should we allow the filtering through type with /files path ? > I am thinking I should change that. Sure, sounds like a neat bonus feature. REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven added inline comments. INLINE COMMENTS > recentlyused.cpp:98 > -// handles type aka mimetype > -if (urlQuery.hasQueryItem(QStringLiteral("type"))) { > -const auto typeValue = > urlQuery.queryItemValue(QStringLiteral("type")); Should we allow the filtering through type

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ivan accepted this revision. REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ngraham accepted this revision. REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65597. meven added a comment. Use new folder-open-recent for /locations REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65492=65597 BRANCH arcpatch-D23742 REVISION DETAIL

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65492. meven added a comment. Use Terms::Type::directories() REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65484=65492 BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65484. meven added a comment. grammar REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65474=65484 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 AFFECTED FILES

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65474. meven added a comment. typo REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65473=65474 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 AFFECTED FILES

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65473. meven added a comment. Replace /folders by /locations, add some documentation REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65470=65473 BRANCH master REVISION DETAIL

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ngraham added a dependent revision: D7446: [Places panel] Revamp the Recently Saved section. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice,

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65470. meven added a comment. Add some const REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65467=65470 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 AFFECTED FILES

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ivan accepted this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65467. meven added a comment. Rephrase 'Recent Folders' to 'Recent Locations' REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65449=65467 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. After applying the full patchset, this works great. It's //exactly// what I was hoping for!  REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven created this revision. meven added reviewers: ivan, ngraham, Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Depends on D23736