D23800: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-10 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R244:76d89c91e05f: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D23800: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-06 Thread Friedrich W. H. Kossebau
kossebau added a comment. @mpyne Thanks for the immediate review and testing In D23800#542391 , @mpyne wrote: > I encountered that excluding deprecated components from the build requires a version of x.y.z. (not just x.y) but other than

D23800: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-05 Thread Michael Pyne
mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. The change looks good and builds in various combinations of CMake options (after I installed the changeset from D23789 ). I encountered that excluding

D23800: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-05 Thread Friedrich W. H. Kossebau
kossebau retitled this revision from "RFC: Use ECMGenerateExportHeader to manage deprecated API better" to "Use ECMGenerateExportHeader to manage deprecated API better". kossebau added reviewers: Frameworks, mpyne. REPOSITORY R244 KCoreAddons REVISION DETAIL