This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.
Closed by commit R295:8f0858eb79a9: Supress mouse events in KCMs causing window
moves (authored by davidedmundson).
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
romangg added a comment.
Forgot that KCMUtils is part of Frameworks... And probably doesn't make sense
to create a bug fix Frameworks release just for that. The KScreen KCM is still
usable, just moving outputs is difficult but also possible. So just push for
next Frameworks release.
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
Let's get it in the beta. But can you reply to @anthonyfieroni inline reply
before pushing?
REPOSITORY
R295 KCMUtils
BRANCH
master
REVISION DETAIL
ngraham added a comment.
+1, fixes the bug.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D24012
To: davidedmundson, #plasma
Cc: ngraham, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
bruns
anthonyfieroni added inline comments.
INLINE COMMENTS
> kcmoduleqml.cpp:265-268
> +bool rc = KCModule::event(event);
> +if (event->type () == QEvent::MouseButtonPress || event->type() ==
> QEvent::MouseButtonRelease) {
> +event->accept();
> +}
Should we check `if (rc &&
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
If a mouse press is handled by the new input handlers the mouse
