dfaure closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24220
To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
ahmadsamir added a comment.
(Please commit this one too).
REPOSITORY
R241 KIO
BRANCH
ahmad/foreach-ioslaves2 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24220
To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
ahmad/foreach-ioslaves2 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24220
To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2,
ahmadsamir updated this revision to Diff 66895.
ahmadsamir added a comment.
Use const local var for implicilty shared qstringlist's to prevent detaching
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24220?vs=66815=66895
BRANCH
ahmad/foreach-ioslaves2
dfaure added inline comments.
INLINE COMMENTS
> ahmadsamir wrote in http.cpp:2612
> Right. A temporary; but since it's a qstringlist it's implicitly shared.
Yes it is, so non-const begin() will detach and make a full copy.
REPOSITORY
R241 KIO
REVISION DETAIL
ahmadsamir added inline comments.
INLINE COMMENTS
> dfaure wrote in http.cpp:2612
> need to move that function call into a const local variable
Right. A temporary; but since it's a qstringlist it's implicitly shared.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24220
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> http.cpp:2612
> qCDebug(KIO_HTTP) << " Sending Header:";
> -Q_FOREACH (const QString , header.split(QStringLiteral("\r\n"),
>
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
TEST PLAN
The code compiles and passes all unit tests
REPOSITORY
R241 KIO
BRANCH
ahmad/foreach-ioslaves2 (branched from
