D24442: ensure winId() not called on non-native widgets

dfaure added a comment. Done, this is in the v5.63.0-rc3 tag now. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

This revision was automatically updated to reflect the committed changes. Closed by commit R252:93c19fbfa125: ensure winId() not called on non-native widgets (authored by cullmann). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

D24442: ensure winId() not called on non-native widgets

cullmann added a comment. It would be great to have that in 5.63, or I am too late? REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24442: ensure winId() not called on non-native widgets

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks good, quite similar to https://phabricator.kde.org/D23808 REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann,

D24442: ensure winId() not called on non-native widgets

cullmann added a comment. If nobody objects will push that later, without any window on secondary screen is garbage after palette change. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks, dfaure Cc: broulik,

D24442: ensure winId() not called on non-native widgets

cullmann added a reviewer: dfaure. cullmann added a comment. If possible I would like to have this in 5.63, as otherwise any color scheme change will make all Qt applications on the non-primary screen unusable with scaling. REPOSITORY R252 Framework Integration REVISION DETAIL

D24442: ensure winId() not called on non-native widgets

cullmann added a comment. Can I merge this? The effect is quiet "evil" here ;=) REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

cullmann added a reviewer: Frameworks. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

cullmann added a comment. For KRun for me the calls there look properly guarded. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

cullmann added a comment. You mean if there are such calls? Can do. Btw., Gwenview doesn't render for me any pictures on the second screen either, but I found there no suspicious code :/ REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To:

D24442: ensure winId() not called on non-native widgets

broulik added a comment. Can you also check `KRun`, I'm sure we've had issues with startup reporting stuff in the past REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24442: ensure winId() not called on non-native widgets

cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY if we do that, window will be corrupted BUG: 412675 TEST PLAN Use Kate, change color theme on a second screen