D24492: [FilteredDirIterator] Reduce stack pressure

hurikhan77 abandoned this revision. hurikhan77 added a comment. Let's close this in favor of https://phabricator.kde.org/D24502 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To: hurikhan77, #baloo Cc: bruns, cullmann, shubham, kde-frameworks-devel, lots0logs,

D24492: [FilteredDirIterator] Reduce stack pressure

bruns added a comment. In D24492#543641 , @hurikhan77 wrote: > Let me change that into a proper loop. See D24502 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To:

D24492: [FilteredDirIterator] Reduce stack pressure

hurikhan77 added a comment. I think we can also assume that using possibly unlimited recursion is also not good practice. Let me change that into a proper loop. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To: hurikhan77, #baloo Cc: cullmann, shubham,

D24492: [FilteredDirIterator] Reduce stack pressure

cullmann added a comment. Yes, I think you want the concept of a loop with continue. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To: hurikhan77, #baloo Cc: cullmann, shubham, kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D24492: [FilteredDirIterator] Reduce stack pressure

shubham added a comment. It is not a good practice to "goto" in C++ REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To: hurikhan77, #baloo Cc: shubham, kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D24492: [FilteredDirIterator] Reduce stack pressure

hurikhan77 created this revision. hurikhan77 added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. hurikhan77 requested review of this revision. REVISION SUMMARY Let's not call ourselves recursively in next() when the currently