D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0911763b8f19: Replace usage of SlaveBase::config() by SlaveBase::mapConfig() (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67943=68017

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D24582 REVISION DETAIL https://phabricator.kde.org/D24582 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven added a comment. In D24582#547267 , @dfaure wrote: > Looks fine, but a bit verbose. Maybe we could have configValue() overloads (in SlaveBase) for bool, int and QString, to cover the most common use cases? > > -

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67943. meven added a comment. Add configValue overloads to simplify code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67772=67943 BRANCH arcpatch-D24582 REVISION DETAIL https://phabricator.kde.org/D24582

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

dfaure added a comment. Looks fine, but a bit verbose. Maybe we could have configValue() overloads (in SlaveBase) for bool, int and QString, to cover the most common use cases? - mapConfig().value(QStringLiteral("MaxCacheAge"), DEFAULT_MAX_CACHE_AGE).toInt(); +

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67772. meven added a comment. Clean up a QVariant() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67771=67772 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582 AFFECTED FILES

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67771. meven added a comment. Fixes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67768=67771 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582 AFFECTED FILES src/ioslaves/file/file.cpp

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67768. meven added a comment. Replace more config() calls, fixes, code cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67767=67768 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67767. meven added a comment. Replace more config() calls, fixes, code cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67765=67767 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24582 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Depends on D23523 Now that