D24593: Modified breeze shadows

niccolove abandoned this revision. niccolove added a comment. Let's try again https://phabricator.kde.org/D25015 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson,

D24593: Modified breeze shadows

ngraham added a comment. Still not working, sorry. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24593: Modified breeze shadows

niccolove added a comment. In D24593#552915 , @ngraham wrote: > Needs a rebase on master. It doesn't apply for me. Does it apply now? If not, I messed up something and I will just reset to master and add the svgs again. REPOSITORY

D24593: Modified breeze shadows

niccolove updated this revision to Diff 68788. niccolove added a comment. Rebase on master - test REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=68626=68788 BRANCH breeze-shadows (branched from master) REVISION DETAIL

D24593: Modified breeze shadows

ngraham added a comment. Needs a rebase on master. It doesn't apply for me. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24593: Modified breeze shadows

niccolove added a comment. In D24593#551591 , @ngraham wrote: > Is this ready for formal review now or are you still tweaking and/or soliciting comments? Ready for review :-) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D24593: Modified breeze shadows

niccolove updated this revision to Diff 68626. niccolove added a comment. Made missing shadow on corners less noticeable on widgets shadows REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=67853=68626 BRANCH breeze-shadows

D24593: Modified breeze shadows

ngraham added a comment. Is this ready for formal review now or are you still tweaking and/or soliciting comments? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson,

D24593: Modified breeze shadows

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24593: Modified breeze shadows

niccolove added a comment. In D24593#546586 , @filipf wrote: > > b) radial gradients instead of linear on the four sides to make the center darker than the angles. > > Other than this, they look great to me. I think they should be uniformly

D24593: Modified breeze shadows

Luwx added a comment. Making good looking pure svg box shadows is a bit tricky. A while back I tried to create one: F7590931: shadow.png The right one uses blur (like breeze decoration does) and the left uses gradients with quite a few

D24593: Modified breeze shadows

filipf added a comment. > b) radial gradients instead of linear on the four sides to make the center darker than the angles. Other than this, they look great to me. I think they should be uniformly dispersed. One of the things with shadows is that the user shouldn't really notice

D24593: Modified breeze shadows

niccolove added a comment. In D24593#546309 , @ngraham wrote: > In D24593#546042 , @niccolove wrote: > > > I'm sorry, when I use scour on svg files, it looks like git does not recognize that the

D24593: Modified breeze shadows

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24593: Modified breeze shadows

niccolove updated this revision to Diff 67853. niccolove added a comment. Re-done the widgets/panel-background.svg REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=67852=67853 BRANCH breeze-shadows (branched from master)

D24593: Modified breeze shadows

niccolove updated this revision to Diff 67852. niccolove added a comment. Re-done the dialogs/background.svg REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=67790=67852 BRANCH breeze-shadows (branched from master) REVISION

D24593: Modified breeze shadows

ngraham added a comment. In D24593#546042 , @niccolove wrote: > I'm sorry, when I use scour on svg files, it looks like git does not recognize that the file has changed. How can I fix that? That means that the files actually haven't

D24593: Modified breeze shadows

niccolove added a comment. I'm sorry, when I use scour on svg files, it looks like git does not recognize that the file has changed. How can I fix that? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: davidedmundson,

D24593: Modified breeze shadows

niccolove updated this revision to Diff 67790. niccolove added a comment. Used scour on svg files REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=67789=67790 BRANCH breeze-shadows (branched from master) REVISION DETAIL

D24593: Modified breeze shadows

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24593: Modified breeze shadows

davidedmundson added a comment. Please write what you've changed and why REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove added a comment. Uhm, I probably got Scour wrong. Sorry. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH breeze-shadows (branched from master) REVISION DETAIL