D24764: Deprecate KIconTheme::assignIconsToContextMenu

vkrause added a comment. Follow up in D24892 to address the latest comments. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D24764 To: vkrause, mlaurent Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24764: Deprecate KIconTheme::assignIconsToContextMenu

kossebau added a comment. As KIconThems supports EXCLUDE_DEPRECATED_BEFORE_AND_AT., you want to also wrap the implementation of assignIconsToContextMenu, with #if KICONTHEMES_BUILD_DEPRECATED_SINCE(5, 64) (look out for _BUILD_). Seems you are a candidate to answer the email https://mail

D24764: Deprecate KIconTheme::assignIconsToContextMenu

This revision was automatically updated to reflect the committed changes. Closed by commit R302:ccf27d634cbf: Deprecate KIconTheme::assignIconsToContextMenu (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24764?vs=68252&id=68555#toc REPOSITORY R302 KIconThemes CH

D24764: Deprecate KIconTheme::assignIconsToContextMenu

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D24764 To: vkrause, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24764: Deprecate KIconTheme::assignIconsToContextMenu

vkrause added a task: T11865: Deprecate KIconTheme::assignIconsToContextMenu. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D24764 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24764: Deprecate KIconTheme::assignIconsToContextMenu

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY It's no longer necessary as Qt sets icons on context menu actions itself by now. REPOSITORY R302 KIconThemes BRANC