This revision was automatically updated to reflect the committed changes.
Closed by commit R241:de3ca85f058e: auto-enable KIO_ASSERT_SLAVE_STATES also
for from-git builds (authored by sitter).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24827?vs=68526=68741
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
assert-for-git
REVISION DETAIL
https://phabricator.kde.org/D24827
To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
sitter updated this revision to Diff 68526.
sitter added a comment.
remove warning
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24827?vs=68428=68526
BRANCH
assert-for-git
REVISION DETAIL
https://phabricator.kde.org/D24827
AFFECTED FILES
sitter marked 3 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24827
To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
sitter edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24827
To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
dfaure added inline comments.
INLINE COMMENTS
> sitter wrote in CMakeLists.txt:49
> Well, at that point you can choose to:
>
> - explicitly -DASSERT_SLAVE_STATES_DEFAULT=OFF which will not trigger the
> warning as the option will not default to the auto detection if you set it
> manually
> -
sitter added inline comments.
INLINE COMMENTS
> dfaure wrote in CMakeLists.txt:49
> It does, but people can still pass -DCMAKE_BUILD_TYPE=Release, or
> RelWithDebInfo (as I do for profiling).
>
> Won't this give them the warning below then, even if they don't set the
> KIO_ASSERT_SLAVE_STATES
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:49
> if(KIO_ASSERT_SLAVE_STATES AND NOT CMAKE_BUILD_TYPE MATCHES "[Dd]ebug$")
> -message(FATAL_ERROR "KIO_ASSERT_SLAVE_STATES option
sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
testing high level functionality of a bunch of relevant slaves yielded no
obvious
