D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

This revision was automatically updated to reflect the committed changes. Closed by commit R302:3ff850df6b48: Fix usage of the new deprecation macros for assignIconsToContextMenu (authored by vkrause). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

vkrause added a comment. In D24892#554048 , @kossebau wrote: > In D24892#553597 , @vkrause wrote: > > > In D24892#552838 , @kossebau wrote: > > > > >

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

vkrause added a task: T11865: Deprecate KIconTheme::assignIconsToContextMenu. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D24892 To: vkrause, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. In D24892#553597 , @vkrause wrote: > In D24892#552838 , @kossebau wrote: > > > Looks good.

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

vkrause added a comment. In D24892#552838 , @kossebau wrote: > Looks good. Perfect would be if you tested KIconThemes with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to hexnumber(5.64.0), to see if there is no internal usage still happening, like

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

kossebau added a comment. Looks good. Perfect would be if you tested KIconThemes with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to hexnumber(5.64.0), to see if there is no internal usage still happening, like with autotests which might need to support such a build with

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

vkrause created this revision. vkrause added a reviewer: kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D24892