This revision was automatically updated to reflect the committed changes.
Closed by commit R263:e9387f561fa2: fix default shortcut detection (authored by
sitter).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D24908?vs=68652=68740#toc
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
ok, fair enough about the tests
INLINE COMMENTS
> sitter wrote in kshortcuteditwidget.cpp:72
> it's initialized to None via the ctor at line 68 already. now that I notice
> it, defaultText
sitter added inline comments.
INLINE COMMENTS
> aacid wrote in kshortcuteditwidget.cpp:72
> this is wrong, isn't it?
>
> Or at least behaviour changing, before m_defaultLabel was set to None, when
> defaultText was empty. Now it's not?
it's initialized to None via the ctor at line 68 already.
aacid added inline comments.
INLINE COMMENTS
> kshortcuteditwidget.cpp:72
> +m_defaultLabel->setText(defaultText);
> }
>
this is wrong, isn't it?
Or at least behaviour changing, before m_defaultLabel was set to None, when
defaultText was empty. Now it's not?
REPOSITORY
R263
sitter added a comment.
Supposedly, I was being lazy though since there is no pre existing test and I
don't exactly know if there's anything to watch out for when testing widgets
(as in: I've never written a widget test before).
REPOSITORY
R263 KXmlGui
REVISION DETAIL
aacid added a comment.
Can this be autotested?
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D24908
To: sitter, dfaure
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
sitter added a reviewer: dfaure.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D24908
To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
sitter edited the test plan for this revision.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D24908
To: sitter
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
When the default shortcut is empty the UI string "None" is used to
indicate that. Alas, when mapping QKeySequences to
