D24978: Add KService::noGlobalShortcut corresponding to X-KDE-NoGlobalShortcut

2019-10-28 Thread Méven Car
meven abandoned this revision. meven added a comment. In D24978#555165 , @apol wrote: > This doesn't look like some API we'd be using very often. Would it make sense to just have kglobalsettings access it through KService::property? I

D24978: Add KService::noGlobalShortcut corresponding to X-KDE-NoGlobalShortcut

2019-10-28 Thread Aleix Pol Gonzalez
apol added a comment. This doesn't look like some API we'd be using very often. Would it make sense to just have kglobalsettings access it through KService::property? INLINE COMMENTS > kservice.cpp:739 > +{ > +if > (qvariant_cast(property(QStringLiteral("X-KDE-NoGlobalShortcut"), >

D24978: Add KService::noGlobalShortcut corresponding to X-KDE-NoGlobalShortcut

2019-10-27 Thread Méven Car
meven created this revision. meven added reviewers: davidre, fvogt, apol, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Currently KglobalAccel uses NoDisplay to disable its component. But