This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R308:7bbd29591094: KRunner: port away from deprecated KF5 API
(authored by dfaure, committed by kossebau).
CHANGED PRIOR
kossebau commandeered this revision.
kossebau edited reviewers, added: dfaure; removed: kossebau.
kossebau added a comment.
This revision now requires review to proceed.
@dfaure I allow myself to take over here given your are off the next days and
I would like to get this off the table :)
kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.
Untested, but looks okay, besides the unneeded #f in the sources.
INLINE COMMENTS
> abstractrunner.cpp:327
>
> +#if PLASMA_ENABLE_DEPRECATED_SINCE(5, 28) // Plasma::Package is
dfaure updated this revision to Diff 69242.
dfaure added a comment.
rebase, add PLASMA_DISABLE_DEPRECATED_BEFORE_AND_AT=0x050500
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24979?vs=68815=69242
BRANCH
D24979
REVISION DETAIL
dfaure added a comment.
Thanks for the detailed analysis. I'm ok with option A. Let's not complicate
this by adding submodule granularity.
I have submitted the removal of the "package" member variable separately,
that one is obvious and almost unrelated.
REPOSITORY
R308 KRunner
kossebau requested changes to this revision.
kossebau added a comment.
This revision now requires changes to proceed.
One of the Interesting challenges with all the cross-library deprecation
visibility control setup.
Let me try to collect requirements:
- Plasma::Package is part of
dfaure created this revision.
dfaure added reviewers: kossebau, mart, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
Plasma::Package has been deprecated since 5.28, but it's used
in the
