cullmann added a comment.
See https://phabricator.kde.org/D25119 for the replacement idea.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D24989
To: cullmann, #frameworks, vonreth, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
cullmann abandoned this revision.
cullmann added a comment.
I think I retract this. I have a nicer way to have this seamless integrated
without KIconThemes.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D24989
To: cullmann, #frameworks, vonreth, dfaure
Cc:
cullmann added a reviewer: dfaure.
cullmann added a comment.
Will alter the initializer before pushing, if it is clarified if the approach
is ok.
Given the lack of mmap for resource files on Windows, I actually would prefer
to hide the resources in dummy plugins, but I guess it would make
vonreth requested changes to this revision.
vonreth added a subscriber: dfaure.
vonreth added a comment.
This revision now requires changes to proceed.
Rest looks good to me.
@dfaure you created the initial version what do you think?
INLINE COMMENTS
> kicontheme.cpp:79
> +for (const
cullmann added reviewers: Frameworks, vonreth.
cullmann added a comment.
To make this usable, we will need to change the way we create the binary
resources in breeze-icons and adapt the craft packaging.
Then we can use e.g. breeze + breeze dark for app store applications like
normally.
cullmann created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cullmann requested review of this revision.
REVISION SUMMARY
Instead of one hard-coded theme, support multiple ones
This assumes that the rccs themself contain a /icons/ prefix
